git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 8/8] t/README: Document the dangers of printing "ok" / "not ok"
Date: Thu,  1 Jul 2010 15:10:04 +0000	[thread overview]
Message-ID: <1277997004-29504-9-git-send-email-avarab@gmail.com> (raw)
In-Reply-To: <1277997004-29504-1-git-send-email-avarab@gmail.com>

A TAP harness will get confused if you print "ok" or "not ok" at the
beginning of a line. This had to be fixed in
335f87871fe5aa6b3fd55b2b4e80f16fe9681483 when TAP support was
introduced.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/README |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/t/README b/t/README
index 42a4c25..29f795e 100644
--- a/t/README
+++ b/t/README
@@ -50,6 +50,12 @@ prove and other harnesses come with a lot of useful options. The
     # Repeat until no more failures
     $ prove -j 15 --state=failed,save ./t[0-9]*.sh
 
+The TAP support is completely incidental. A TAP harness is just a
+program that interprets the "ok"/"not ok" (and some other strings) in
+a special way. The only limitation this imposes is that you shouldn't
+echo "ok" or "not ok" by yourself at the beginning of a line, that'll
+confuse the TAP harness.
+
 You can also run each test individually from command line, like this:
 
     $ ./t3010-ls-files-killed-modified.sh
-- 
1.7.1.251.g92a7

  parent reply	other threads:[~2010-07-01 15:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 15:09 [PATCH 0/8] Improvements for t/README Ævar Arnfjörð Bjarmason
2010-07-01 15:09 ` [PATCH 1/8] t/README: Tests are all +x, ./test, not sh ./test Ævar Arnfjörð Bjarmason
2010-07-01 15:42   ` Jeff King
2010-07-01 15:09 ` [PATCH 2/8] t/README: The trash is in 't/trash directory.$name' Ævar Arnfjörð Bjarmason
2010-07-01 15:44   ` Jeff King
2010-07-01 15:09 ` [PATCH 3/8] t/README: Typo: paralell -> parallel Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` [PATCH 4/8] t/README: Document the prereq functions, and 3-arg test_* Ævar Arnfjörð Bjarmason
2010-07-01 16:37   ` Junio C Hamano
2010-07-01 15:10 ` [PATCH 5/8] t/README: Document test_external* Ævar Arnfjörð Bjarmason
2010-07-01 16:38   ` Junio C Hamano
2010-07-01 15:10 ` [PATCH 6/8] t/README: Document test_expect_code Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` [PATCH 7/8] t/README: Add a section about skipping tests Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-01 17:16   ` [PATCH 8/8] t/README: Document the dangers of printing "ok" / "not ok" Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277997004-29504-9-git-send-email-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).