git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: jeffpc@josefsipek.net
Cc: Git Mailing List <git@vger.kernel.org>, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] guilt: Make sure the commit time is increasing
Date: Sun,  4 Jul 2010 22:23:59 -0400	[thread overview]
Message-ID: <1278296639-25024-1-git-send-email-tytso@mit.edu> (raw)

Git has various algorithms, most notably in git rev-list, git
name-rev, and others, which depend on the commit time increasing.  We
want to keep the commit time the same as much as possible, but if
necessary, adjust the time stamps of the patch files to obey this
constraint.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 guilt |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/guilt b/guilt
index b6e2a6c..2371e98 100755
--- a/guilt
+++ b/guilt
@@ -535,6 +535,13 @@ commit()
                         export GIT_AUTHOR_EMAIL="`echo $author_str | sed -e 's/[^<]*//'`"
 		fi
 
+		ct=$(git log -1 --pretty=%ct)
+		if [ $ct -gt $(stat -c %Y "$p") ]; then
+		    echo "Warning time went backwards, adjusting mod time of" \
+			$(basename "$p")
+		    touch -d @$(expr $ct + 60) "$p" || touch "$p"
+		fi
+
 		# must strip nano-second part otherwise git gets very
 		# confused, and makes up strange timestamps from the past
 		# (chances are it decides to interpret it as a unix
-- 
1.7.0.4

             reply	other threads:[~2010-07-05  2:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  2:23 Theodore Ts'o [this message]
2010-07-05  2:51 ` [PATCH] guilt: Make sure the commit time is increasing tytso
2010-07-05  3:01   ` jeffpc
2010-07-05  2:59 ` jeffpc
2010-07-05 11:06   ` Theodore Tso
2010-07-05 18:52     ` jeffpc
2010-07-05 19:22       ` tytso
2010-07-06  8:03         ` Jonathan Nieder
2010-07-06 10:56           ` Theodore Tso
2010-07-06 15:09             ` Jonathan Nieder
2010-07-06 17:12               ` tytso
2010-07-06 17:29                 ` Jonathan Nieder
2010-07-06 13:53           ` Erik Faye-Lund
2010-07-06 14:29             ` Jeff King
2010-07-06 15:02               ` Erik Faye-Lund
2010-07-06 17:21                 ` tytso
2010-07-06 17:29         ` jeffpc
2010-07-06 18:57           ` tytso
2010-07-14  3:01         ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278296639-25024-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=jeffpc@josefsipek.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).