git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, agladysh@gmail.com,
	Elijah Newren <newren@gmail.com>
Subject: [PATCHv4 2/6] Add a rename + D/F conflict testcase
Date: Fri,  9 Jul 2010 07:10:52 -0600	[thread overview]
Message-ID: <1278681056-31460-3-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1278681056-31460-1-git-send-email-newren@gmail.com>

From: Alexander Gladysh <agladysh@gmail.com>

This is a simple testcase where both sides of the rename are paths involved
in (separate) D/F merge conflicts

Signed-off-by: Alexander Gladysh <agladysh@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Junio was also curious in the last round how well the resolve strategy
handled this testcase.  It passes.  I could add it as a testcase, but use
of the --strategy option for cherry-pick would make the series no longer
apply to maint.  However, if that is wanted, I can add it.

 t/t3509-cherry-pick-merge-df.sh |   35 +++++++++++++++++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100755 t/t3509-cherry-pick-merge-df.sh

diff --git a/t/t3509-cherry-pick-merge-df.sh b/t/t3509-cherry-pick-merge-df.sh
new file mode 100755
index 0000000..7c05e16
--- /dev/null
+++ b/t/t3509-cherry-pick-merge-df.sh
@@ -0,0 +1,35 @@
+#!/bin/sh
+
+test_description='Test cherry-pick with directory/file conflicts'
+. ./test-lib.sh
+
+test_expect_success 'Setup rename across paths each below D/F conflicts' '
+	mkdir a &&
+	>a/f &&
+	git add a &&
+	git commit -m a &&
+
+	mkdir b &&
+	ln -s ../a b/a &&
+	git add b &&
+	git commit -m b &&
+
+	git checkout -b branch &&
+	rm b/a &&
+	mv a b/a &&
+	ln -s b/a a &&
+	git add . &&
+	git commit -m swap &&
+
+	>f1 &&
+	git add f1 &&
+	git commit -m f1
+'
+
+test_expect_failure 'Cherry-pick succeeds with rename across D/F conflicts' '
+	git reset --hard &&
+	git checkout master^0 &&
+	git cherry-pick branch
+'
+
+test_done
-- 
1.7.1.1.23.gafea6

  parent reply	other threads:[~2010-07-09 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 13:10 [PATCHv4 0/6] D/F conflict fixes Elijah Newren
2010-07-09 13:10 ` [PATCHv4 1/6] Add additional testcases for D/F conflicts Elijah Newren
2010-07-09 13:10 ` Elijah Newren [this message]
2010-07-09 13:10 ` [PATCHv4 3/6] merge-recursive: Fix " Elijah Newren
2010-07-09 13:10 ` [PATCHv4 4/6] merge_recursive: Fix renames across paths below " Elijah Newren
2010-07-09 13:10 ` [PATCHv4 5/6] fast-export: Fix output order of D/F changes Elijah Newren
2010-07-09 13:10 ` [PATCHv4 6/6] fast-import: Improve robustness when D->F changes provided in wrong order Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278681056-31460-3-git-send-email-newren@gmail.com \
    --to=newren@gmail.com \
    --cc=agladysh@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).