git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Yang <struggleyb.nku@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH v3 01/13] parse-options: stop when encounter a non-option
Date: Sun, 11 Jul 2010 14:18:49 +0800	[thread overview]
Message-ID: <1278829141-11900-1-git-send-email-struggleyb.nku@gmail.com> (raw)

We support the syntax like:
-L n1,m1 pathspec1 -L n2,m2 pathspec2.

Make the parse-options API not stop when encounter a
non-option argument, report the status and go on parsing
the remain options.

Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
---
 parse-options.c |    3 ++-
 parse-options.h |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/parse-options.c b/parse-options.c
index 0fa79bc..cbb49d3 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -374,7 +374,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
 			if (parse_nodash_opt(ctx, arg, options) == 0)
 				continue;
 			if (ctx->flags & PARSE_OPT_STOP_AT_NON_OPTION)
-				break;
+				return PARSE_OPT_NON_OPTION;
 			ctx->out[ctx->cpidx++] = ctx->argv[0];
 			continue;
 		}
@@ -456,6 +456,7 @@ int parse_options(int argc, const char **argv, const char *prefix,
 	switch (parse_options_step(&ctx, options, usagestr)) {
 	case PARSE_OPT_HELP:
 		exit(129);
+	case PARSE_OPT_NON_OPTION:
 	case PARSE_OPT_DONE:
 		break;
 	default: /* PARSE_OPT_UNKNOWN */
diff --git a/parse-options.h b/parse-options.h
index 7435cdb..407697a 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -161,7 +161,8 @@ extern NORETURN void usage_msg_opt(const char *msg,
 enum {
 	PARSE_OPT_HELP = -1,
 	PARSE_OPT_DONE,
-	PARSE_OPT_UNKNOWN
+	PARSE_OPT_NON_OPTION,
+	PARSE_OPT_UNKNOWN,
 };
 
 /*
-- 
1.7.0.2.273.gc2413.dirty

             reply	other threads:[~2010-07-11  6:21 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11  6:18 Bo Yang [this message]
2010-07-11  6:18 ` [PATCH v3 02/13] parse-options: add two helper functions Bo Yang
2010-07-12 16:45   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 03/13] add the basic data structure for line level history Bo Yang
2010-07-12 14:16   ` Bo Yang
2010-07-12 16:50     ` Junio C Hamano
2010-07-18 14:35       ` Bo Yang
2010-07-11  6:18 ` [PATCH v3 04/13] refactor parse_loc Bo Yang
2010-07-12 18:32   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 05/13] parse the -L options Bo Yang
2010-07-13 23:03   ` Junio C Hamano
2010-07-18 14:49     ` Bo Yang
2010-07-19 18:44       ` Junio C Hamano
2010-07-19 22:48         ` Thomas Rast
2010-07-19 23:53           ` Junio C Hamano
2010-07-20  7:51             ` Thomas Rast
2010-07-20 15:45               ` Junio C Hamano
2010-07-22  9:06                 ` Thomas Rast
2010-07-23  2:08                   ` Junio C Hamano
2010-07-20 15:46               ` Bo Yang
2010-07-20 15:47                 ` Bo Yang
2010-07-11  6:18 ` [PATCH v3 06/13] export three functions from diff.c Bo Yang
2010-07-11  6:18 ` [PATCH v3 07/13] add range clone functions Bo Yang
2010-07-12 21:52   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 08/13] map/take range to parent Bo Yang
2010-07-12 21:52   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 09/13] print the line log Bo Yang
2010-07-12 21:52   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 10/13] map/print ranges along traversing the history topologically Bo Yang
2010-07-12 21:52   ` Junio C Hamano
2010-07-11  6:18 ` [PATCH v3 11/13] add --always-print option Bo Yang
2010-07-13 20:35   ` Junio C Hamano
2010-07-11  6:19 ` [PATCH v3 12/13] add two test cases Bo Yang
2010-07-11  6:19 ` [PATCH v3 13/13] some document update Bo Yang
2010-07-11  8:27   ` Jakub Narebski
2010-07-12 14:12     ` Bo Yang
2010-07-12 18:45       ` Junio C Hamano
2010-07-18 14:37         ` Bo Yang
2010-07-12 16:45 ` [PATCH v3 01/13] parse-options: stop when encounter a non-option Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278829141-11900-1-git-send-email-struggleyb.nku@gmail.com \
    --to=struggleyb.nku@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).