From: Bo Yang <struggleyb.nku@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Jens.Lehmann@web.de, trast@student.ethz.ch
Subject: [PATCH v1 2/4] add parent rewrite feature to line level log
Date: Sun, 11 Jul 2010 14:27:35 +0800 [thread overview]
Message-ID: <1278829657-26607-3-git-send-email-struggleyb.nku@gmail.com> (raw)
In-Reply-To: <1278829657-26607-1-git-send-email-struggleyb.nku@gmail.com>
Two kinds of commit are qualified as a parent:
1. The commit touch some lines of the current
interesting range;
2. The commit is a merge commit.
So, there will be more commits output than the
situation which parent rewrite is not set on.
Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
---
line.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
line.h | 2 +
revision.c | 3 ++
3 files changed, 96 insertions(+), 3 deletions(-)
diff --git a/line.c b/line.c
index c08b510..0d62732 100644
--- a/line.c
+++ b/line.c
@@ -10,6 +10,9 @@
#include "xdiff-interface.h"
#include "strbuf.h"
#include "log-tree.h"
+#include "graph.h"
+
+static int limited = 0;
static void cleanup(struct diff_line_range *r)
{
@@ -1213,12 +1216,12 @@ int cmd_line_log_walk(struct rev_info *rev)
die("revision walk prepare failed");
list = rev->commits;
- if (list) {
+ if (list && !limited) {
list->item->object.flags |= RANGE_UPDATE;
list = list->next;
}
/* Clear the flags */
- while (list) {
+ while (list && !limited) {
list->item->object.flags &= 0x0;
list = list->next;
}
@@ -1232,7 +1235,9 @@ int cmd_line_log_walk(struct rev_info *rev)
assign_parents_range(rev, commit);
}
- if (commit->object.flags & NEED_PRINT || rev->always_print) {
+ if (commit->object.flags & NEED_PRINT || rev->always_print || rev->graph) {
+ if (rev->graph)
+ graph_update(rev->graph, commit);
line_log_flush(rev, commit);
}
@@ -1257,3 +1262,86 @@ int cmd_line_log_walk(struct rev_info *rev)
return 0;
}
+static enum rewrite_result rewrite_one(struct rev_info *rev, struct commit **pp)
+{
+ struct diff_line_range *r = NULL;
+ struct commit *p;
+ while (1) {
+ p = *pp;
+ if (p->object.flags & RANGE_UPDATE)
+ assign_parents_range(rev, p);
+ if (p->parents && p->parents->next)
+ return rewrite_one_ok;
+ if (p->object.flags & NEED_PRINT)
+ return rewrite_one_ok;
+ if (!p->parents)
+ return rewrite_one_noparents;
+
+ r = lookup_line_range(rev, p);
+ if (!r)
+ return rewrite_one_noparents;
+ *pp = p->parents->item;
+ }
+}
+
+/* The rev->commits must be sorted in topologically order */
+void limit_list_line(struct rev_info *rev)
+{
+ struct commit_list *list = rev->commits;
+ struct commit_list *commits = xmalloc(sizeof(struct commit_list));
+ struct commit_list *out = commits, *prev = commits;
+ struct commit *c;
+ struct diff_line_range *r;
+
+ if (list) {
+ list->item->object.flags |= RANGE_UPDATE;
+ list = list->next;
+ }
+ /* Clear the flags */
+ while (list) {
+ list->item->object.flags &= 0x0;
+ list = list->next;
+ }
+
+ list = rev->commits;
+ while (list) {
+ c = list->item;
+
+ if (c->object.flags & RANGE_UPDATE)
+ assign_parents_range(rev, c);
+
+ if (c->object.flags & NEED_PRINT ||
+ (c->parents && c->parents->next)) {
+ if (rewrite_parents(rev, c, rewrite_one))
+ die("Can't rewrite parent for commit %s",
+ sha1_to_hex(c->object.sha1));
+ commits->item = c;
+ commits->next = xmalloc(sizeof(struct commit_list));
+ prev = commits;
+ commits = commits->next;
+ } else {
+ r = lookup_line_range(rev, c);
+ if (r) {
+ cleanup(r);
+ r = NULL;
+ add_line_range(rev, c, r);
+ }
+ }
+
+ list = list->next;
+ }
+
+ prev->next = NULL;
+ free(commits);
+
+ list = rev->commits;
+ while (list) {
+ struct commit_list *l = list;
+ list = list->next;
+ free(l);
+ }
+
+ rev->commits = out;
+ limited = 1;
+}
+
diff --git a/line.h b/line.h
index b293894..90d7c1a 100644
--- a/line.h
+++ b/line.h
@@ -130,4 +130,6 @@ const char *parse_loc(const char *spec, nth_line_fn_t nth_line,
extern int cmd_line_log_walk(struct rev_info *rev);
+extern void limit_list_line(struct rev_info *rev);
+
#endif
diff --git a/revision.c b/revision.c
index 72d9654..659cec7 100644
--- a/revision.c
+++ b/revision.c
@@ -13,6 +13,7 @@
#include "decorate.h"
#include "log-tree.h"
#include "string-list.h"
+#include "line.h"
volatile show_early_output_fn_t show_early_output;
@@ -1886,6 +1887,8 @@ int prepare_revision_walk(struct rev_info *revs)
return -1;
if (revs->topo_order)
sort_in_topological_order(&revs->commits, revs->lifo);
+ if (revs->rewrite_parents && revs->line)
+ limit_list_line(revs);
if (revs->simplify_merges)
simplify_merges(revs);
if (revs->children.name)
--
1.7.0.2.273.gc2413.dirty
next prev parent reply other threads:[~2010-07-11 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 6:27 [PATCH v1 0/4] add parent rewrite feature to line level log Bo Yang
2010-07-11 6:27 ` [PATCH v1 1/4] make rewrite_parents an external function Bo Yang
2010-07-14 19:10 ` Junio C Hamano
2010-07-11 6:27 ` Bo Yang [this message]
2010-07-13 20:47 ` [PATCH v1 2/4] add parent rewrite feature to line level log Junio C Hamano
2010-07-11 6:27 ` [PATCH v1 3/4] line.c output the '--graph' padding before each line Bo Yang
2010-07-13 20:49 ` Junio C Hamano
2010-07-11 6:27 ` [PATCH v1 4/4] add test cases for '--graph' of line level log Bo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278829657-26607-3-git-send-email-struggleyb.nku@gmail.com \
--to=struggleyb.nku@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).