git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, johan@herland.net,
	Lars Hjemli <hjemli@gmail.com>,
	nanako3@lavabit.com, adam@adamsimpkins.net
Subject: [PATCH 0/2] Preparing the graph API for external users
Date: Tue, 13 Jul 2010 23:23:37 +0200	[thread overview]
Message-ID: <1279056219-27096-1-git-send-email-johan@herland.net> (raw)

Hi,

I'm playing around with some CGit patches for enabling an ASCII-art
commit graph to be displayed on CGit's 'log' page. These patches reuse
the ASCII-art commit graph that is produced by 'git log --graph'.

However, in order to allow proper reuse by CGit, I need to make a
couple of changes to the graph API:

The first patch exposes graph_next_line() in the graph.h API. This
function is needed to drive the graph generation from CGit. (Since
the graph_show_* functions print directly to stdout, they can not be
used by CGit.)

The second patch allows CGit to use a different coloring mechanism
than the default ANSI color escapes in graph.c. CGit replaces the
column_colors array of ANSI escapes in graph.c with its own array that
contains HTML <span> tags (which are then styled to the appropriate
colors using CSS).

For reference, the corresponding CGit patches that generate the commit
graph on CGit's log page will follow as a separate patch series.


Johan Herland (2):
  Make graph_next_line() available in the graph.h API
  Enable custom schemes for column colors in the graph API

 graph.c |   50 +++++++++++++++++++++++++++-----------------------
 graph.h |   28 ++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+), 23 deletions(-)

             reply	other threads:[~2010-07-13 21:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 21:23 Johan Herland [this message]
2010-07-13 21:23 ` [PATCH 1/2] Make graph_next_line() available in the graph.h API Johan Herland
2010-07-13 21:23 ` [PATCH 2/2] Enable custom schemes for column colors in the graph API Johan Herland
2010-07-13 21:40 ` [CGit RFC/PATCH 0/5] Commit graph on CGit's 'log' view Johan Herland
2010-07-13 22:57   ` Lars Hjemli
2010-07-14  5:59     ` Johan Herland
2010-07-18 13:26       ` Lars Hjemli
2010-07-13 21:40 ` [CGit RFC/PATCH 1/5] ui-stats: Remove unnecessary #include Johan Herland
2010-07-13 21:40 ` [CGit RFC/PATCH 2/5] ui-log: Move 'Age' column to the right of 'Author', like in gitk Johan Herland
2010-07-13 21:40 ` [CGit RFC/PATCH 3/5] ui-log: Refactor display of commit messages Johan Herland
2010-07-13 21:40 ` [CGit RFC/PATCH 4/5] ui-log: Implement support for commit graphs Johan Herland
2010-07-13 21:40 ` [CGit RFC/PATCH 5/5] ui-log: Colorize commit graph Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279056219-27096-1-git-send-email-johan@herland.net \
    --to=johan@herland.net \
    --cc=adam@adamsimpkins.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hjemli@gmail.com \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).