From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: David Michael Barr <david.barr@cordelta.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
avarab@gmail.com, Daniel Shahaf <d.s@daniel.shahaf.name>,
Bert Huijben <rhuijben@collab.net>,
Junio C Hamano <gitster@pobox.com>,
Eric Wong <normalperson@yhbt.net>,
Will Palmer <wpalmer@gmail.com>, Greg Stein <gstein@gmail.com>
Subject: [PATCH 8/9] Implement close_file
Date: Wed, 14 Jul 2010 01:36:15 +0200 [thread overview]
Message-ID: <1279064176-6645-9-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1279064176-6645-1-git-send-email-artagnon@gmail.com>
close_file measures the length of the temporary file to write text
headers and full text before cleaning up the temporary file. It also
writes props and prop deltas if necessary.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
dump_editor.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 76 insertions(+), 0 deletions(-)
diff --git a/dump_editor.c b/dump_editor.c
index 8b0a830..b2fd3d6 100644
--- a/dump_editor.c
+++ b/dump_editor.c
@@ -533,7 +533,82 @@ static svn_error_t *close_file(void *file_baton,
const char *text_checksum,
apr_pool_t *pool)
{
+ struct dump_edit_baton *eb = file_baton;
+ apr_file_t *temp_file;
+ svn_stream_t *temp_filestream;
+ apr_finfo_t *info = apr_pcalloc(pool, sizeof(apr_finfo_t));
+
+ /* We didn't write the property headers because we were
+ waiting for file_prop_change; write them now */
+ SVN_ERR(dump_props(eb, &(eb->dump_props_pending), FALSE, pool));
+
+ /* The prop headers have already been dumped in dump_node */
+ /* Dump the text headers */
+ if (eb->must_dump_text) {
+ /* text-delta header */
+ SVN_ERR(svn_stream_printf(eb->stream, pool,
+ SVN_REPOS_DUMPFILE_TEXT_DELTA
+ ": true\n"));
+
+ /* Measure the length */
+ SVN_ERR(svn_io_stat(info, eb->temp_filepath, APR_FINFO_SIZE, pool));
+
+ /* text-content-length header */
+ SVN_ERR(svn_stream_printf(eb->stream, pool,
+ SVN_REPOS_DUMPFILE_TEXT_CONTENT_LENGTH
+ ": %lu\n",
+ (unsigned long)info->size));
+ /* text-content-md5 header */
+ SVN_ERR(svn_stream_printf(eb->stream, pool,
+ SVN_REPOS_DUMPFILE_TEXT_CONTENT_MD5
+ ": %s\n",
+ text_checksum));
+ }
+
+ /* content-length header: if both text and props are absent,
+ skip this block */
+ if (eb->must_dump_props || eb->dump_props_pending)
+ SVN_ERR(svn_stream_printf(eb->stream, pool,
+ SVN_REPOS_DUMPFILE_CONTENT_LENGTH
+ ": %ld\n\n",
+ (unsigned long)info->size + eb->propstring->len));
+ else if (eb->must_dump_text)
+ SVN_ERR(svn_stream_printf(eb->stream, pool,
+ SVN_REPOS_DUMPFILE_CONTENT_LENGTH
+ ": %ld\n\n",
+ (unsigned long)info->size));
+
+ /* Dump the props; the propstring should have already been
+ written in dump_node or above */
+ if (eb->must_dump_props || eb->dump_props_pending) {
+ SVN_ERR(svn_stream_write(eb->stream, eb->propstring->data,
+ &(eb->propstring->len)));
+
+ /* Cleanup */
+ eb->must_dump_props = eb->dump_props_pending = FALSE;
+ apr_hash_clear(eb->properties);
+ apr_hash_clear(eb->del_properties);
+ }
+
+ /* Dump the text */
+ if (eb->must_dump_text) {
+
+ /* Open the temporary file, map it to a stream, copy
+ the stream to eb->stream, close and delete the
+ file */
+ SVN_ERR(svn_io_file_open(&temp_file, eb->temp_filepath, APR_READ, 0600, pool));
+ temp_filestream = svn_stream_from_aprfile2(temp_file, TRUE, pool);
+ SVN_ERR(svn_stream_copy3(temp_filestream, eb->stream, NULL, NULL, pool));
+
+ /* Cleanup */
+ SVN_ERR(svn_io_file_close(temp_file, pool));
+ SVN_ERR(svn_stream_close(temp_filestream));
+ SVN_ERR(svn_io_remove_file2(eb->temp_filepath, TRUE, pool));
+ eb->must_dump_text = FALSE;
+ }
+
+ SVN_ERR(svn_stream_printf(eb->stream, pool, "\n\n"));
+
return SVN_NO_ERROR;
}
--
1.7.1
next prev parent reply other threads:[~2010-07-13 23:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 23:36 [PATCH 0/9] Get svnrdump merged into git.git Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 1/9] Add LICENSE Ramkumar Ramachandra
2010-07-14 4:47 ` Daniel Shahaf
2010-07-14 11:23 ` Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 2/9] Add skeleton SVN client and Makefile Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 3/9] Add debug editor from Subversion trunk Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 4/9] Drive the debug editor Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 5/9] Dump the revprops at the start of every revision Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 6/9] Implement directory-related functions Ramkumar Ramachandra
2010-07-13 23:36 ` [PATCH 7/9] Implement file-related functions Ramkumar Ramachandra
2010-07-13 23:36 ` Ramkumar Ramachandra [this message]
2010-07-13 23:36 ` [PATCH 9/9] Add a validation script Ramkumar Ramachandra
2010-07-13 23:58 ` [PATCH 0/9] Get svnrdump merged into git.git Ramkumar Ramachandra
2010-07-14 0:15 ` Jonathan Nieder
2010-07-14 0:22 ` Ramkumar Ramachandra
2010-07-14 0:28 ` Jonathan Nieder
2010-07-14 0:49 ` Ramkumar Ramachandra
2010-07-14 7:03 ` Stefan Sperling
2010-07-14 11:26 ` Ramkumar Ramachandra
2010-07-14 12:55 ` Stefan Sperling
2010-07-14 14:54 ` Junio C Hamano
2010-07-15 10:55 ` Ramkumar Ramachandra
[not found] ` <20100806175709.GA2683@burratino>
2010-08-06 18:37 ` [PATCH svnrdump-standalone] Sync with upstream Jonathan Nieder
2010-08-07 2:30 ` Jonathan Nieder
2010-08-07 2:47 ` Ramkumar Ramachandra
2010-08-07 2:51 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279064176-6645-9-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gstein@gmail.com \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=rhuijben@collab.net \
--cc=srabbelier@gmail.com \
--cc=wpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).