git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erick Mattos <erick.mattos@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Erick Mattos <erick.mattos@gmail.com>
Subject: [PATCH] t2017: redo physical reflog existance check
Date: Wed, 21 Jul 2010 22:46:30 -0300	[thread overview]
Message-ID: <1279763190-32757-1-git-send-email-erick.mattos@gmail.com> (raw)

Commit 6e6842e wiped out physical reflog checks of tests because of
redundancy and to hide low level detail of the implementation.

Although this is not a problem to all the other changes, it is laming to
the tenth test.  The implementation of the correspondent problem creates
a "touch" reflog that must be wiped out if not used by committing the
new branch.

Signed-off-by: Erick Mattos <erick.mattos@gmail.com>
---
 t/t2017-checkout-orphan.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/t/t2017-checkout-orphan.sh b/t/t2017-checkout-orphan.sh
index 2d2f63f..0d5d0a0 100755
--- a/t/t2017-checkout-orphan.sh
+++ b/t/t2017-checkout-orphan.sh
@@ -93,8 +93,10 @@ test_expect_success '--orphan with -l makes reflog when core.logAllRefUpdates =
 test_expect_success 'giving up --orphan not committed when -l and core.logAllRefUpdates = false deletes reflog' '
 	git checkout master &&
 	git checkout -l --orphan eta &&
+	test -f .git/logs/refs/heads/eta &&
 	test_must_fail git rev-parse --verify eta@{0} &&
 	git checkout master &&
+	! test -f .git/logs/refs/heads/eta &&
 	test_must_fail git rev-parse --verify eta@{0}
 '
 
-- 
1.7.2.1.ga86e3

             reply	other threads:[~2010-07-22  1:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22  1:46 Erick Mattos [this message]
2010-07-22 17:35 ` [PATCH] t2017: redo physical reflog existance check Junio C Hamano
2010-07-22 18:58   ` Erick Mattos
2010-07-23  2:23     ` Junio C Hamano
2010-07-23 15:04       ` Erick Mattos
2010-08-24  4:03         ` Jonathan Nieder
2010-08-24 16:57           ` Junio C Hamano
2010-08-24 18:57           ` Erick Mattos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279763190-32757-1-git-send-email-erick.mattos@gmail.com \
    --to=erick.mattos@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).