git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lynn.Lin@emc.com
To: git@vger.kernel.org
Cc: Lynn Lin <Lynn.Lin@emc.com>
Subject: [PATCH] Makefile: don't include git  version file on 'make clean'
Date: Sat, 24 Jul 2010 11:53:47 +0800	[thread overview]
Message-ID: <1279943627-11053-1-git-send-email-Lynn.Lin@emc.com> (raw)

From: Lynn Lin <Lynn.Lin@emc.com>

---
 Makefile         |    4 +++-
 git-gui/Makefile |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index bc3c570..eb28b98 100644
--- a/Makefile
+++ b/Makefile
@@ -238,7 +238,9 @@ all::
 
 GIT-VERSION-FILE: FORCE
 	@$(SHELL_PATH) ./GIT-VERSION-GEN
--include GIT-VERSION-FILE
+ifneq "$(MAKECMDGOALS)" "clean"
+  -include GIT-VERSION-FILE
+endif
 
 uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
 uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
diff --git a/git-gui/Makefile b/git-gui/Makefile
index 197b55e..91e1ea5 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -9,7 +9,9 @@ all::
 
 GIT-VERSION-FILE: FORCE
 	@$(SHELL_PATH) ./GIT-VERSION-GEN
--include GIT-VERSION-FILE
+ifneq "$(MAKECMDGOALS)" "clean"
+  -include GIT-VERSION-FILE
+endif
 
 uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
 uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
-- 
1.7.1

             reply	other threads:[~2010-07-24  3:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24  3:53 Lynn.Lin [this message]
2010-07-24 12:36 ` [PATCH] Makefile: don't include git version file on 'make clean' Ævar Arnfjörð Bjarmason
2010-07-25  8:49   ` Kevin P. Fleming
2010-07-25 11:28     ` lynn.lin
2010-07-25 11:41       ` Ævar Arnfjörð Bjarmason
2010-07-25 11:46         ` lynn.lin
2010-07-25 11:55           ` Ævar Arnfjörð Bjarmason
2010-07-25 12:02             ` lynn.lin
2010-07-25 12:10               ` Ævar Arnfjörð Bjarmason
2010-07-25 12:05             ` Andreas Schwab
2010-07-25 12:15               ` Ævar Arnfjörð Bjarmason
2010-07-25 12:19                 ` lynn.lin
2010-07-25 12:21                   ` lynn.lin
2010-07-25 12:29                     ` lynn.lin
2010-07-25 12:34                       ` Ævar Arnfjörð Bjarmason
2010-07-25 12:37                         ` lynn.lin
2010-07-25 13:08                           ` Ævar Arnfjörð Bjarmason
2010-07-25 13:21                             ` lynn.lin
2010-07-25 18:49 ` Patch follow-up conventions (Re: [PATCH] Makefile: don't include git version file on 'make clean') Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279943627-11053-1-git-send-email-Lynn.Lin@emc.com \
    --to=lynn.lin@emc.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).