From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: git@vger.kernel.org
Subject: [PATCH v2] revert: only suggest to commit if not passing -n
Date: Sun, 25 Jul 2010 05:54:30 -0700 [thread overview]
Message-ID: <1280062470-21891-1-git-send-email-carenas@sajinet.com.pe> (raw)
In-Reply-To: <20100723164218.GA2284@localhost.localdomain>
while doing revert or cherry-pick, if the automatic merge fails
and the user specifically suggested he didn't want to commit,
then don't suggest to do that as part of the conflict resolution.
Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
---
builtin/revert.c | 20 ++++++++++++--------
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c
index 8b9d829..b7cb69b 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -250,14 +250,18 @@ static char *help_msg(void)
return msg;
strbuf_addstr(&helpbuf, " After resolving the conflicts,\n"
- "mark the corrected paths with 'git add <paths>' or 'git rm <paths>'\n"
- "and commit the result");
+ "mark the corrected paths with 'git add <paths>' or 'git rm <paths>'");
+ if (!no_commit) {
+ strbuf_addstr(&helpbuf, "\nand commit the result");
- if (action == CHERRY_PICK) {
- strbuf_addf(&helpbuf, " with: \n"
- "\n"
- " git commit -c %s\n",
- sha1_to_hex(commit->object.sha1));
+ if (action == CHERRY_PICK) {
+ strbuf_addf(&helpbuf, " with: \n"
+ "\n"
+ " git commit -c %s\n",
+ sha1_to_hex(commit->object.sha1));
+ }
+ else
+ strbuf_addch(&helpbuf, '.');
}
else
strbuf_addch(&helpbuf, '.');
--
1.7.2
next prev parent reply other threads:[~2010-07-25 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 13:51 [PATCH] revert: only suggest to commit if not passing -n Carlo Marcelo Arenas Belon
2010-07-23 16:42 ` Jared Hance
2010-07-25 12:54 ` Carlo Marcelo Arenas Belon [this message]
2010-08-13 4:54 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280062470-21891-1-git-send-email-carenas@sajinet.com.pe \
--to=carenas@sajinet.com.pe \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).