git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	David Barr <david.barr@cordelta.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/3] vcs-svn: Remove stray calls to removed functions
Date: Thu, 29 Jul 2010 11:06:18 +0530	[thread overview]
Message-ID: <1280381780-6265-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1280381780-6265-1-git-send-email-artagnon@gmail.com>

repo_tree.c makes calls to non-existant commit_init, dir_init and
dirent_init functions, and string_pool.c makes a call to non-existant
string_init function. These functions were previously generated in
obj_pool.h before persistence in svn-fe was turned off.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 vcs-svn/repo_tree.c   |    3 ---
 vcs-svn/string_pool.c |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c
index c27d077..1ce184d 100644
--- a/vcs-svn/repo_tree.c
+++ b/vcs-svn/repo_tree.c
@@ -308,9 +308,6 @@ static void mark_init(void)
 
 void repo_init() {
 	pool_init();
-	commit_init();
-	dir_init();
-	dirent_init();
 	mark_init();
 	if (commit_pool.size == 0) {
 		/* Create empty tree for commit 0. */
diff --git a/vcs-svn/string_pool.c b/vcs-svn/string_pool.c
index bd5a380..616b17e 100644
--- a/vcs-svn/string_pool.c
+++ b/vcs-svn/string_pool.c
@@ -93,7 +93,6 @@ void pool_init(void)
 {
 	uint32_t node;
 	uint32_t string = 0;
-	string_init();
 	while (string < string_pool.size) {
 		node = node_alloc(1);
 		node_pointer(node)->offset = string;
-- 
1.7.1

  reply	other threads:[~2010-07-29  5:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  5:36 [PATCH 0/3] svn-fe fixes Ramkumar Ramachandra
2010-07-29  5:36 ` Ramkumar Ramachandra [this message]
2010-07-29  5:36 ` [PATCH 2/3] contrib/svn-fe: Fix IncludePath Ramkumar Ramachandra
2010-07-29  5:36 ` [PATCH 3/3] contrib/svn-fe: Add the svn-fe target to .gitignore Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280381780-6265-2-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=david.barr@cordelta.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).