git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: [PATCH 0/5 v3] log and diff: accept detached forms (--option value)
Date: Thu, 29 Jul 2010 10:20:24 +0200	[thread overview]
Message-ID: <1280391629-30017-1-git-send-email-Matthieu.Moy@imag.fr> (raw)

Since last version :

* I had missed several optional arguments, for which detached form
  should not be allowed (otherwise, --option --other-option is
  ambiguous). In most cases, my changes were harmless since the code
  had already checked for the parameterless form before reaching mine,
  but that was definitely bad anyway.

* One missing "return optarg;" (that even Jonathan had missed ;-) )

* One more test for "git log -S" failure (no argument to -S)

* Refactoring by Jonathan Nieder for --stat-*

* Rewording of commit messages.

Jonathan Nieder (1):
  diff: split off a function for --stat-* option parsing

Matthieu Moy (4):
  diff: parse detached options like -S foo
  diff: parse detached options --stat-width n, --stat-name-width n
  log: parse detached options like git log --grep foo
  log: parse detached option for --glob

 diff.c                       |  167 +++++++++++++++++++++++++++++++-----------
 diff.h                       |    7 ++
 revision.c                   |   79 +++++++++++++-------
 t/t4013-diff-various.sh      |    5 +
 t/t4013/diff.log_-S_F_master |    7 ++
 t/t4202-log.sh               |   19 +++--
 t/t6018-rev-list-glob.sh     |    6 ++
 7 files changed, 211 insertions(+), 79 deletions(-)
 create mode 100644 t/t4013/diff.log_-S_F_master

-- 
1.7.2.21.ge9796

             reply	other threads:[~2010-07-29  8:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  8:20 Matthieu Moy [this message]
2010-07-29  8:20 ` [PATCH 1/5] diff: parse detached options like -S foo Matthieu Moy
2010-07-29  8:20 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-29  8:20 ` [PATCH 3/5] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-07-29  8:20 ` [PATCH 4/5] log: parse detached options like git log --grep foo Matthieu Moy
2010-07-29 22:25   ` Jonathan Nieder
2010-07-30  8:27     ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 1/5 v4] diff: parse detached options like -S foo Matthieu Moy
2010-08-02 16:46         ` Junio C Hamano
2010-08-02 19:43           ` Matthieu Moy
2010-08-02 19:47           ` Jonathan Nieder
2010-07-30  8:31       ` [PATCH 2/5 v4] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-30  8:31       ` [PATCH 3/5 v4] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-02 16:56         ` Junio C Hamano
2010-08-02 18:47           ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 4/5 v4] log: parse detached options like git log --grep foo Matthieu Moy
2010-08-02 17:03         ` Junio C Hamano
2010-08-02 18:55           ` Matthieu Moy
2010-08-02 21:28             ` Junio C Hamano
2010-08-03  6:33               ` Matthieu Moy
2010-08-03 17:16                 ` Junio C Hamano
2010-08-03 19:52                   ` Matthieu Moy
2010-08-04  2:41                   ` Miles Bader
2010-07-30  8:31       ` [PATCH 5/5 v4] log: parse detached option for --glob Matthieu Moy
2010-07-29  8:20 ` [PATCH 5/5] " Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280391629-30017-1-git-send-email-Matthieu.Moy@imag.fr \
    --to=matthieu.moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).