git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: [PATCH 3/5] diff: parse detached options --stat-width n, --stat-name-width n
Date: Thu, 29 Jul 2010 10:20:27 +0200	[thread overview]
Message-ID: <1280391629-30017-4-git-send-email-Matthieu.Moy@imag.fr> (raw)
In-Reply-To: <1280391629-30017-1-git-send-email-Matthieu.Moy@imag.fr>

Part of a campaign for unstuck forms of options.

[jn: with some refactoring]

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 diff.c |   28 +++++++++++++++++++++++-----
 1 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/diff.c b/diff.c
index d5f5d4b..90b07e1 100644
--- a/diff.c
+++ b/diff.c
@@ -3035,16 +3035,34 @@ static int stat_opt(struct diff_options *options, const char **av)
 	char *end;
 	int width = options->stat_width;
 	int name_width = options->stat_name_width;
+	int argcount = 1;
 
 	arg += strlen("--stat");
 	end = (char *)arg;
 
 	switch (*arg) {
 	case '-':
-		if (!prefixcmp(arg, "-width="))
-			width = strtoul(arg + 7, &end, 10);
-		else if (!prefixcmp(arg, "-name-width="))
-			name_width = strtoul(arg + 12, &end, 10);
+		if (!prefixcmp(arg, "-width")) {
+			arg += strlen("-width");
+			if (*arg == '=')
+				width = strtoul(arg + 1, &end, 10);
+			else if (!*arg && !av[1])
+				die("Option '--stat-width' requires a value");
+			else if (!*arg) {
+				width = strtoul(av[1], &end, 10);
+				argcount = 2;
+			}
+		} else if (!prefixcmp(arg, "-name-width")) {
+			arg += strlen("-name-width");
+			if (*arg == '=')
+				name_width = strtoul(arg + 1, &end, 10);
+			else if (!*arg && !av[1])
+				die("Option '--stat-name-width' requires a value");
+			else if (!*arg) {
+				name_width = strtoul(av[1], &end, 10);
+				argcount = 2;
+			}
+		}
 		break;
 	case '=':
 		width = strtoul(arg+1, &end, 10);
@@ -3058,7 +3076,7 @@ static int stat_opt(struct diff_options *options, const char **av)
 	options->output_format |= DIFF_FORMAT_DIFFSTAT;
 	options->stat_name_width = name_width;
 	options->stat_width = width;
-	return 1;
+	return argcount;
 }
 
 int diff_opt_parse(struct diff_options *options, const char **av, int ac)
-- 
1.7.2.21.ge9796

  parent reply	other threads:[~2010-07-29  8:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  8:20 [PATCH 0/5 v3] log and diff: accept detached forms (--option value) Matthieu Moy
2010-07-29  8:20 ` [PATCH 1/5] diff: parse detached options like -S foo Matthieu Moy
2010-07-29  8:20 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-29  8:20 ` Matthieu Moy [this message]
2010-07-29  8:20 ` [PATCH 4/5] log: parse detached options like git log --grep foo Matthieu Moy
2010-07-29 22:25   ` Jonathan Nieder
2010-07-30  8:27     ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 1/5 v4] diff: parse detached options like -S foo Matthieu Moy
2010-08-02 16:46         ` Junio C Hamano
2010-08-02 19:43           ` Matthieu Moy
2010-08-02 19:47           ` Jonathan Nieder
2010-07-30  8:31       ` [PATCH 2/5 v4] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-30  8:31       ` [PATCH 3/5 v4] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-02 16:56         ` Junio C Hamano
2010-08-02 18:47           ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 4/5 v4] log: parse detached options like git log --grep foo Matthieu Moy
2010-08-02 17:03         ` Junio C Hamano
2010-08-02 18:55           ` Matthieu Moy
2010-08-02 21:28             ` Junio C Hamano
2010-08-03  6:33               ` Matthieu Moy
2010-08-03 17:16                 ` Junio C Hamano
2010-08-03 19:52                   ` Matthieu Moy
2010-08-04  2:41                   ` Miles Bader
2010-07-30  8:31       ` [PATCH 5/5 v4] log: parse detached option for --glob Matthieu Moy
2010-07-29  8:20 ` [PATCH 5/5] " Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280391629-30017-4-git-send-email-Matthieu.Moy@imag.fr \
    --to=matthieu.moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).