From: Daniel Johnson <computerdruid@gmail.com>
To: git@vger.kernel.org
Cc: "Daniel Johnson" <ComputerDruid@gmail.com>,
"Kristian Høgsberg" <krh@redhat.com>
Subject: [PATCH/RFC] fetch: allow command line --tags to override config
Date: Wed, 4 Aug 2010 14:56:42 -0400 [thread overview]
Message-ID: <1280948202-17385-1-git-send-email-ComputerDruid@gmail.com> (raw)
Originally, if remote.<name>.tagopt was set, the --tags and option would
have no effect when given to git fetch. So if
tagopt="--no-tags"
git fetch --tags
would not actually fetch tags.
This patch changes this behavior to only follow what is written in the
config if there is no option passed by the command line.
Signed-off-by: Daniel Johnson <ComputerDruid@gmail.com>
---
builtin/fetch.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 1b67f5f..7a53144 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -675,10 +675,12 @@ static int do_fetch(struct transport *transport,
for_each_ref(add_existing, &existing_refs);
- if (transport->remote->fetch_tags == 2 && tags != TAGS_UNSET)
- tags = TAGS_SET;
- if (transport->remote->fetch_tags == -1)
- tags = TAGS_UNSET;
+ if (tags == TAGS_DEFAULT) {
+ if (transport->remote->fetch_tags == 2)
+ tags = TAGS_SET;
+ if (transport->remote->fetch_tags == -1)
+ tags = TAGS_UNSET;
+ }
if (!transport->get_refs_list || !transport->fetch)
die("Don't know how to fetch from %s", transport->url);
--
1.7.2
next reply other threads:[~2010-08-04 18:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 18:56 Daniel Johnson [this message]
2010-08-05 9:56 ` [PATCH/RFC] fetch: allow command line --tags to override config Tay Ray Chuan
2010-08-06 13:54 ` [PATCH] Documentation: changes in the behavior of tagopt Daniel Johnson
2010-08-08 2:17 ` Tay Ray Chuan
2010-08-11 22:57 ` [RFC/PATCHv2] fetch: allow command line --tags to override config Daniel Johnson
2010-08-13 1:22 ` Junio C Hamano
2010-08-13 20:13 ` [RFC/PATCH] t5525: test the tagopt variable and that it can be overridden Daniel Johnson
2010-08-13 20:55 ` Ævar Arnfjörð Bjarmason
2010-08-13 21:27 ` [RFC/PATCHv2] " Daniel Johnson
2010-08-13 21:39 ` Ævar Arnfjörð Bjarmason
2010-08-14 21:32 ` Daniel Johnson
2010-08-14 21:37 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280948202-17385-1-git-send-email-ComputerDruid@gmail.com \
--to=computerdruid@gmail.com \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).