From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: [PATCH 3/5] diff: parse separate options --stat-width n, --stat-name-width n
Date: Thu, 5 Aug 2010 10:22:54 +0200 [thread overview]
Message-ID: <1280996576-1165-3-git-send-email-Matthieu.Moy@imag.fr> (raw)
In-Reply-To: <vpqmxt14gjt.fsf@bauges.imag.fr>
Part of a campaign for unstuck forms of options.
[jn: with some refactoring]
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
diff.c | 28 +++++++++++++++++++++++-----
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/diff.c b/diff.c
index a08a56a..e98d59b 100644
--- a/diff.c
+++ b/diff.c
@@ -3035,16 +3035,34 @@ static int stat_opt(struct diff_options *options, const char **av)
char *end;
int width = options->stat_width;
int name_width = options->stat_name_width;
+ int argcount = 1;
arg += strlen("--stat");
end = (char *)arg;
switch (*arg) {
case '-':
- if (!prefixcmp(arg, "-width="))
- width = strtoul(arg + 7, &end, 10);
- else if (!prefixcmp(arg, "-name-width="))
- name_width = strtoul(arg + 12, &end, 10);
+ if (!prefixcmp(arg, "-width")) {
+ arg += strlen("-width");
+ if (*arg == '=')
+ width = strtoul(arg + 1, &end, 10);
+ else if (!*arg && !av[1])
+ die("Option '--stat-width' requires a value");
+ else if (!*arg) {
+ width = strtoul(av[1], &end, 10);
+ argcount = 2;
+ }
+ } else if (!prefixcmp(arg, "-name-width")) {
+ arg += strlen("-name-width");
+ if (*arg == '=')
+ name_width = strtoul(arg + 1, &end, 10);
+ else if (!*arg && !av[1])
+ die("Option '--stat-name-width' requires a value");
+ else if (!*arg) {
+ name_width = strtoul(av[1], &end, 10);
+ argcount = 2;
+ }
+ }
break;
case '=':
width = strtoul(arg+1, &end, 10);
@@ -3058,7 +3076,7 @@ static int stat_opt(struct diff_options *options, const char **av)
options->output_format |= DIFF_FORMAT_DIFFSTAT;
options->stat_name_width = name_width;
options->stat_width = width;
- return 1;
+ return argcount;
}
int diff_opt_parse(struct diff_options *options, const char **av, int ac)
--
1.7.2.1.30.g18195
next prev parent reply other threads:[~2010-08-05 8:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 22:24 What's cooking in git.git (Aug 2010, #01; Wed, 4) Junio C Hamano
2010-08-05 0:16 ` jk/tag-contains: stalled Ted Ts'o
2010-08-05 16:29 ` Junio C Hamano
2010-08-05 17:05 ` Junio C Hamano
2010-08-05 17:36 ` Jeff King
2010-08-05 18:47 ` Junio C Hamano
2010-08-05 19:06 ` Jeff King
2010-08-05 19:18 ` Jay Soffian
2010-08-05 19:27 ` Jeff King
2010-08-05 20:00 ` Jay Soffian
2010-08-05 20:36 ` Ted Ts'o
2010-08-05 20:53 ` Junio C Hamano
2010-08-05 21:38 ` Thomas Rast
2010-08-05 22:15 ` Junio C Hamano
2010-08-06 5:44 ` Junio C Hamano
2010-08-05 6:53 ` tc/checkout-B Jonathan Nieder
2010-08-05 10:18 ` tc/checkout-B Tay Ray Chuan
2010-08-05 8:20 ` What's cooking in git.git (Aug 2010, #01; Wed, 4) Matthieu Moy
2010-08-05 8:22 ` [PATCH 1/5] diff: parse separate options like -S foo Matthieu Moy
2010-08-05 12:16 ` Jakub Narebski
2010-08-05 12:24 ` Matthieu Moy
2010-08-05 8:22 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-08-05 8:22 ` Matthieu Moy [this message]
2010-08-05 8:22 ` [PATCH 4/5] log: parse separate options like git log --grep foo Matthieu Moy
2010-08-05 8:22 ` [PATCH 5/5] log: parse separate option for --glob Matthieu Moy
2010-08-05 11:41 ` mm/shortopt-detached Jonathan Nieder
2010-08-05 21:12 ` jc/sha1-name-find-fix Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280996576-1165-3-git-send-email-Matthieu.Moy@imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).