From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: [PATCH 5/5] log: parse separate option for --glob
Date: Thu, 5 Aug 2010 10:22:56 +0200 [thread overview]
Message-ID: <1280996576-1165-5-git-send-email-Matthieu.Moy@imag.fr> (raw)
In-Reply-To: <vpqmxt14gjt.fsf@bauges.imag.fr>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
revision.c | 7 +++++--
t/t6018-rev-list-glob.sh | 6 ++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/revision.c b/revision.c
index 489a3c2..f241f34 100644
--- a/revision.c
+++ b/revision.c
@@ -1484,6 +1484,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
{
int i, flags, left, seen_dashdash, read_from_stdin, got_rev_arg = 0;
const char **prune_data = NULL;
+ const char *optarg;
+ int argcount;
/* First, search for "--" */
seen_dashdash = 0;
@@ -1530,10 +1532,11 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
handle_refs(revs, flags, for_each_remote_ref);
continue;
}
- if (!prefixcmp(arg, "--glob=")) {
+ if ((argcount = parse_long_opt("glob", argv + i, &optarg))) {
struct all_refs_cb cb;
+ i += argcount - 1;
init_all_refs_cb(&cb, revs, flags);
- for_each_glob_ref(handle_one_ref, arg + 7, &cb);
+ for_each_glob_ref(handle_one_ref, optarg, &cb);
continue;
}
if (!prefixcmp(arg, "--branches=")) {
diff --git a/t/t6018-rev-list-glob.sh b/t/t6018-rev-list-glob.sh
index 58428d9..fb8291c 100755
--- a/t/t6018-rev-list-glob.sh
+++ b/t/t6018-rev-list-glob.sh
@@ -123,6 +123,12 @@ test_expect_success 'rev-list --glob=refs/heads/subspace/*' '
'
+test_expect_success 'rev-list --glob refs/heads/subspace/*' '
+
+ compare rev-list "subspace/one subspace/two" "--glob refs/heads/subspace/*"
+
+'
+
test_expect_success 'rev-list --glob=heads/subspace/*' '
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/*"
--
1.7.2.1.30.g18195
next prev parent reply other threads:[~2010-08-05 8:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 22:24 What's cooking in git.git (Aug 2010, #01; Wed, 4) Junio C Hamano
2010-08-05 0:16 ` jk/tag-contains: stalled Ted Ts'o
2010-08-05 16:29 ` Junio C Hamano
2010-08-05 17:05 ` Junio C Hamano
2010-08-05 17:36 ` Jeff King
2010-08-05 18:47 ` Junio C Hamano
2010-08-05 19:06 ` Jeff King
2010-08-05 19:18 ` Jay Soffian
2010-08-05 19:27 ` Jeff King
2010-08-05 20:00 ` Jay Soffian
2010-08-05 20:36 ` Ted Ts'o
2010-08-05 20:53 ` Junio C Hamano
2010-08-05 21:38 ` Thomas Rast
2010-08-05 22:15 ` Junio C Hamano
2010-08-06 5:44 ` Junio C Hamano
2010-08-05 6:53 ` tc/checkout-B Jonathan Nieder
2010-08-05 10:18 ` tc/checkout-B Tay Ray Chuan
2010-08-05 8:20 ` What's cooking in git.git (Aug 2010, #01; Wed, 4) Matthieu Moy
2010-08-05 8:22 ` [PATCH 1/5] diff: parse separate options like -S foo Matthieu Moy
2010-08-05 12:16 ` Jakub Narebski
2010-08-05 12:24 ` Matthieu Moy
2010-08-05 8:22 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-08-05 8:22 ` [PATCH 3/5] diff: parse separate options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-05 8:22 ` [PATCH 4/5] log: parse separate options like git log --grep foo Matthieu Moy
2010-08-05 8:22 ` Matthieu Moy [this message]
2010-08-05 11:41 ` mm/shortopt-detached Jonathan Nieder
2010-08-05 21:12 ` jc/sha1-name-find-fix Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280996576-1165-5-git-send-email-Matthieu.Moy@imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).