git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, santi@agolina.net,
	Johannes.Schindelin@gmx.de, Elijah Newren <newren@gmail.com>
Subject: [PATCHv2 1/2] t5520-pull: Add testcases showing spurious conflicts from git pull --rebase
Date: Sun,  8 Aug 2010 13:04:45 -0600	[thread overview]
Message-ID: <1281294286-27709-2-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1281294286-27709-1-git-send-email-newren@gmail.com>


Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t5520-pull.sh |   58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 58 insertions(+), 0 deletions(-)

diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
index 319e389..1624dd3 100755
--- a/t/t5520-pull.sh
+++ b/t/t5520-pull.sh
@@ -160,4 +160,62 @@ test_expect_success 'pull --rebase works on branch yet to be born' '
 	test_cmp expect actual
 '
 
+test_expect_success 'setup for detecting upstreamed changes' '
+	mkdir src &&
+	(cd src &&
+	 git init &&
+	 for i in $(seq 1 10); do echo $i; done > stuff &&
+	 git add stuff &&
+	 git commit -m "Initial revision"
+	) &&
+	git clone src dst &&
+	(cd src &&
+	 perl -pi -e s/5/43/ stuff &&
+	 git commit -a -m "5->43" &&
+	 perl -pi -e s/6/42/ stuff &&
+	 git commit -a -m "Make it bigger" &&
+	 correct=$(git rev-parse HEAD)
+	) &&
+	(cd dst &&
+	 perl -pi -e s/5/43/ stuff &&
+	 git commit -a -m "Independent discovery of 5->43"
+	)
+'
+
+test_expect_failure 'git pull --rebase detects upstreamed changes' '
+	(cd dst &&
+	 git pull --rebase &&
+	 test -z "$(git ls-files -u)"
+	)
+'
+
+test_expect_success 'setup for avoiding reapplying old patches' '
+	(cd dst &&
+	 (git rebase --abort || true) &&
+	 git reset --hard origin/master
+	) &&
+	git clone --bare src src-replace.git &&
+	rm -rf src &&
+	mv src-replace.git src &&
+	(cd dst &&
+	 perl -pi -e s/2/22/ stuff &&
+	 git commit -a -m "Change 2" &&
+	 perl -pi -e s/3/33/ stuff &&
+	 git commit -a -m "Change 3" &&
+	 perl -pi -e s/4/44/ stuff &&
+	 git commit -a -m "Change 4" &&
+	 git push &&
+
+	 perl -pi -e s/44/55/ stuff &&
+	 git commit --amend -a -m "Modified Change 4"
+	)
+'
+
+test_expect_failure 'git pull --rebase does not reapply old patches' '
+	(cd dst &&
+	 (git pull --rebase || true) &&
+	 test 1 = $(find .git/rebase-apply -name "000*" | wc -l)
+	)
+'
+
 test_done
-- 
1.7.2.1

  reply	other threads:[~2010-08-08 18:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-08 19:04 [PATCHv2 0/2] Fix spurious conflicts with pull --rebase Elijah Newren
2010-08-08 19:04 ` Elijah Newren [this message]
2010-08-08 20:01   ` [PATCHv2 1/2] t5520-pull: Add testcases showing spurious conflicts from git " Ævar Arnfjörð Bjarmason
2010-08-08 20:17     ` Elijah Newren
2010-08-08 20:33       ` Ævar Arnfjörð Bjarmason
2010-08-08 21:36   ` Johannes Sixt
2010-08-08 21:43     ` Jonathan Nieder
2010-08-08 19:04 ` [PATCHv2 2/2] pull --rebase: Avoid spurious conflicts and reapplying unnecessary patches Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281294286-27709-2-git-send-email-newren@gmail.com \
    --to=newren@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=santi@agolina.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).