git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, santi@agolina.net,
	Johannes.Schindelin@gmx.de, avarab@gmail.com,
	Elijah Newren <newren@gmail.com>
Subject: [PATCHv3 0/2] Fix spurious conflicts with pull --rebase
Date: Sun,  8 Aug 2010 14:55:15 -0600	[thread overview]
Message-ID: <1281300917-5610-1-git-send-email-newren@gmail.com> (raw)

This patch series fixes spurious conflict issues with git pull
--rebase for the case where the upstream repository is *not* rebased.
(There is no change in the case where the upstream repository is
rebased.)

In c85c79279d and d44e71261f, the call to git-rebase was modified in
an effort to reduce the number of commits being reapplied, by trying
to avoid commits that upstream already had or has.  It was
specifically designed with an upstream that is rebased in mind.
Unfortunately, it had two side effects for the non-rebased upstream
case: (1) it prevented detecting if "local" patches are already
upstream, and (2) it could in some cases cause more patches known to
be upstream to be reapplied rather than less.  This series fixes both
of these issues for the non-rebased upstream case.  See the commit
message of the second patch for details.

It's worth noting that issue (1) above also affects the case where the
upstream repository has been rebased, which this patch series does not
address.  As far as I can tell, fixing it would require changes
(including new syntax) to format-patch to allow it to be told what
'upstream' is, and some changes to git-pull.sh/git-rebase.sh to pass
it this information.

Changes since the last series:
  * Address issues in t5520-pull.sh raised by Ævar Arnfjörð Bjarmason

Elijah Newren (2):
  t5520-pull: Add testcases showing spurious conflicts from git pull
    --rebase
  pull --rebase: Avoid spurious conflicts and reapplying unnecessary
    patches

 git-pull.sh     |   34 +++++++++++++++++++----------
 t/t5520-pull.sh |   63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+), 12 deletions(-)

-- 
1.7.2.1

             reply	other threads:[~2010-08-08 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-08 20:55 Elijah Newren [this message]
2010-08-08 20:55 ` [PATCHv3 1/2] t5520-pull: Add testcases showing spurious conflicts from git pull --rebase Elijah Newren
2010-08-09  0:43   ` Elijah Newren
2010-08-09 19:09   ` Junio C Hamano
2010-08-09 19:22     ` Elijah Newren
2010-08-09 20:35       ` Ævar Arnfjörð Bjarmason
2010-08-08 20:55 ` [PATCHv3 2/2] pull --rebase: Avoid spurious conflicts and reapplying unnecessary patches Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281300917-5610-1-git-send-email-newren@gmail.com \
    --to=newren@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=santi@agolina.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).