From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v2 4/4] t/t0000-basic.sh: Run the passing TODO test inside its own test-lib Date: Wed, 18 Aug 2010 13:34:33 +0000 Message-ID: <1282138473-15613-5-git-send-email-avarab@gmail.com> References: <7vpqxhaw92.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Aug 18 15:35:20 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OlinS-0005kI-Uy for gcvg-git-2@lo.gmane.org; Wed, 18 Aug 2010 15:35:15 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199Ab0HRNfI convert rfc822-to-quoted-printable (ORCPT ); Wed, 18 Aug 2010 09:35:08 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:55971 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093Ab0HRNfG (ORCPT ); Wed, 18 Aug 2010 09:35:06 -0400 Received: by mail-wy0-f174.google.com with SMTP id 32so790682wyb.19 for ; Wed, 18 Aug 2010 06:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=H9qz7rqoJ6gm64pEMBqm6lWiNaH2KlmetEjfuMD8cwM=; b=SSHQceEKCuQ16WQaYTBy00AQ+KHabO4SjuKj4G+RMeU0JU4u/s6nvYqXf2OmPhZCWv HW5IQSnjhLDnjggtODFWxm8nosSishyjfpfMRXyOIny4IoKsIH+wmP2tiVRLF+S5a+1x iXLC5JWX4+VQyztj9zX7zlZxZHL7MYYKPg+Jw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; b=I5LtiiJc05kIdFwaDip8L9RnDsIpv3gjM+u0Z0cd98N/hxO4bW2wTY8znatLQxCDxr cwt+s7rhzz6KUufehESFUGD/GkTWWzQrhkouCY/kTIHKITncbuvYSirUwywexcOBTnvu tJrtpZ4jlyeFZgGCreg7f48pmkcTlUsso1rJY= Received: by 10.227.69.17 with SMTP id x17mr7171906wbi.87.1282138505650; Wed, 18 Aug 2010 06:35:05 -0700 (PDT) Received: from v.nix.is (v.nix.is [109.74.193.250]) by mx.google.com with ESMTPS id r10sm230012wbe.18.2010.08.18.06.35.01 (version=SSLv3 cipher=RC4-MD5); Wed, 18 Aug 2010 06:35:02 -0700 (PDT) X-Mailer: git-send-email 1.7.2.1.414.g9bf49 In-Reply-To: <7vpqxhaw92.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Change the passing TODO test in t0000-basic.sh to run inside its own test-lib.sh. The motivation is to have nothing out of the ordinary on a normal test run for test smoking purposes. If every normal test run has a passing TODO you're more likely to turn a blind eye to it and not to investigate cases where things really are passing unexpectedly. It also makes the prove(1) output less noisy. Before: All tests successful. Test Summary Report ------------------- ./t0000-basic.sh (Wstat: 0 Tests:= 46 Failed: 0) TODO passed: 5 Files=3D484, Tests=3D6229, 143 wallclock secs ( 4.00 usr 4.15 sys = + 104.77 cusr 351.57 csys =3D 464.49 CPU) Result: PASS And after: All tests successful. Files=3D484, Tests=3D6228, 139 wallclock secs ( 4.07 usr 4.25 sys = + 104.54 cusr 350.85 csys =3D 463.71 CPU) Result: PASS Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason --- t/t0000-basic.sh | 31 +++++++++++++++++++++++++++++++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index 9602085..1a977db 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -54,9 +54,40 @@ test_expect_success 'success is reported like this' = ' test_expect_failure 'pretend we have a known breakage' ' false ' + +test_expect_success 'pretend we have fixed a known breakage (run in su= b test-lib)' " + mkdir passing-todo && + (cd passing-todo && + cat >passing-todo.sh <out 2>err && + ! test -s err && +cat >expect <