From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH 0/4] rev-parse: improve reporting of invalid log references
Date: Sat, 21 Aug 2010 11:43:38 +1000 [thread overview]
Message-ID: <1282355022-17795-1-git-send-email-jon.seymour@gmail.com> (raw)
In-Reply-To: <AANLkTi=m7+h0nVg+EAmiir-rnrjoBwbpLtztcNNBVxiz@mail.gmail.com>
This series fixes git rev-parse so that references of the form ref@{n}
cause rev-parse to fail with non-zero status codes when n >= N, where
N is the size of the reflog for ref.
The first commit causes git rev-parse to exit with a non-zero
status code but has the flaw that the error message is duplicated
if --verify is not specified.
The second commit fixes the duplicate error messages produced by
the first commit, but prevents the diagnostic being displayed
if the --verify option is specified.
The third commit restores the diagnostic if the --verify
option is specified.
The fourth commit adds tests for the changed behaviour.
Jon Seymour (4):
rev-parse: exit with non-zero status if ref@{n} is not valid.
rev-parse: suppress duplicate log limit exceeded message.
rev-parse: introduce get_sha1_with_gently
rev-parse: tests that git rev-parse --verify master@{n}
builtin/rev-parse.c | 2 +-
cache.h | 1 +
sha1_name.c | 52 ++++++++++++++++++++++++---------------
t/t1503-rev-parse-verify.sh | 11 ++++++++
t/t1506-rev-parse-diagnosis.sh | 9 +++++++
5 files changed, 54 insertions(+), 21 deletions(-)
--
1.7.2.1.152.g499e.dirty
next prev parent reply other threads:[~2010-08-21 1:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 11:36 RFD: should git rev-parse exit with non-zero status if ref@{n} is not valid? Jon Seymour
2010-08-18 11:41 ` Jon Seymour
2010-08-18 20:50 ` Junio C Hamano
2010-08-18 23:02 ` Jon Seymour
2010-08-21 1:43 ` Jon Seymour [this message]
2010-08-21 1:43 ` [PATCH 1/4] rev-parse: exit with non-zero status if ref@{n} is not valid Jon Seymour
2010-08-21 1:43 ` [PATCH 2/4] rev-parse: suppress duplicate log limit exceeded message Jon Seymour
2010-08-22 21:20 ` Junio C Hamano
2010-08-23 14:59 ` Jon Seymour
2010-08-23 16:33 ` Junio C Hamano
2010-08-23 23:11 ` [PATCH v2 0/2] rev-parse: strengthen validation of ref@{n} references Jon Seymour
2010-08-23 23:11 ` [PATCH v2 1/2] rev-parse: exit with non-zero status if ref@{n} is not valid Jon Seymour
2010-08-24 0:14 ` Jonathan Nieder
2010-08-24 4:52 ` [PATCH v3 0/3] rev-parse: strengthen validation of ref@{n} references Jon Seymour
2010-08-24 4:52 ` [PATCH v3 1/3] rev-parse: exit with non-zero status if ref@{n} is not valid Jon Seymour
2010-08-24 4:52 ` [PATCH v3 2/3] sha1_name.c: use warning in preference to fprintf(stderr Jon Seymour
2010-08-24 4:52 ` [PATCH v3 3/3] rev-parse: tests git rev-parse --verify master@{n}, for various n Jon Seymour
2010-08-23 23:11 ` [PATCH v2 2/2] " Jon Seymour
2010-08-21 1:43 ` [PATCH 3/4] rev-parse: introduce get_sha1_gently Jon Seymour
2010-08-21 1:43 ` [PATCH 4/4] rev-parse: tests that git rev-parse --verify master@{n} Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282355022-17795-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).