From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, jrnieder@gmail.com,
Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v3 0/3] rev-parse: strengthen validation of ref@{n} references
Date: Tue, 24 Aug 2010 14:52:41 +1000 [thread overview]
Message-ID: <1282625564-12752-1-git-send-email-jon.seymour@gmail.com> (raw)
In-Reply-To: <20100824001454.GB17406@burratino>
This series changes git rev-parse so that references of the form:
ref@{n}
cause rev-parse to fail with a non-zero status code if n >= size of the
reference log for ref.
The first commit implements the changed behaviour; the second commit
replaces uses of fprintf (within sha1_name.c) with warning;
the third commit updates the tests to include tests for the changed behaviour.
This is the third revision of this series. It differs from the first
in that it uses die rather than error to report the condition
and thus exits early, without generating any output on stdout
for the failing argument. It also reports just a single fatal
message instead of both an error message and a fatal message.
The original patch and this revision are both based on suggestions
from Junio. Corrections to diagnostic output inspired by Jonathan Nieder's
review.
Jon Seymour (3):
rev-parse: exit with non-zero status if ref@{n} is not valid.
sha1_name.c: use warning in preference to fprintf(stderr
rev-parse: tests git rev-parse --verify master@{n}, for various n
sha1_name.c | 20 +++++++++++---------
t/t1503-rev-parse-verify.sh | 11 +++++++++++
t/t1506-rev-parse-diagnosis.sh | 9 +++++++++
3 files changed, 31 insertions(+), 9 deletions(-)
--
1.7.2.1.100.gceecd
next prev parent reply other threads:[~2010-08-24 4:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 11:36 RFD: should git rev-parse exit with non-zero status if ref@{n} is not valid? Jon Seymour
2010-08-18 11:41 ` Jon Seymour
2010-08-18 20:50 ` Junio C Hamano
2010-08-18 23:02 ` Jon Seymour
2010-08-21 1:43 ` [PATCH 0/4] rev-parse: improve reporting of invalid log references Jon Seymour
2010-08-21 1:43 ` [PATCH 1/4] rev-parse: exit with non-zero status if ref@{n} is not valid Jon Seymour
2010-08-21 1:43 ` [PATCH 2/4] rev-parse: suppress duplicate log limit exceeded message Jon Seymour
2010-08-22 21:20 ` Junio C Hamano
2010-08-23 14:59 ` Jon Seymour
2010-08-23 16:33 ` Junio C Hamano
2010-08-23 23:11 ` [PATCH v2 0/2] rev-parse: strengthen validation of ref@{n} references Jon Seymour
2010-08-23 23:11 ` [PATCH v2 1/2] rev-parse: exit with non-zero status if ref@{n} is not valid Jon Seymour
2010-08-24 0:14 ` Jonathan Nieder
2010-08-24 4:52 ` Jon Seymour [this message]
2010-08-24 4:52 ` [PATCH v3 1/3] " Jon Seymour
2010-08-24 4:52 ` [PATCH v3 2/3] sha1_name.c: use warning in preference to fprintf(stderr Jon Seymour
2010-08-24 4:52 ` [PATCH v3 3/3] rev-parse: tests git rev-parse --verify master@{n}, for various n Jon Seymour
2010-08-23 23:11 ` [PATCH v2 2/2] " Jon Seymour
2010-08-21 1:43 ` [PATCH 3/4] rev-parse: introduce get_sha1_gently Jon Seymour
2010-08-21 1:43 ` [PATCH 4/4] rev-parse: tests that git rev-parse --verify master@{n} Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282625564-12752-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).