From: Elijah Newren <newren@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Elijah Newren <newren@gmail.com>
Subject: [PATCH 3/7] tree-walk: Correct bitrotted comment about tree_entry()
Date: Tue, 24 Aug 2010 20:53:11 -0600 [thread overview]
Message-ID: <1282704795-29661-4-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1282704795-29661-1-git-send-email-newren@gmail.com>
There was a code comment that referred to the "above two functions" but
over time the functions immediately preceding the comment have changed.
Just mention the relevant functions by name.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
tree-walk.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tree-walk.h b/tree-walk.h
index 42110a4..a5175fa 100644
--- a/tree-walk.h
+++ b/tree-walk.h
@@ -28,7 +28,9 @@ static inline int tree_entry_len(const char *name, const unsigned char *sha1)
void update_tree_entry(struct tree_desc *);
void init_tree_desc(struct tree_desc *desc, const void *buf, unsigned long size);
-/* Helper function that does both of the above and returns true for success */
+/* Helper function that does both tree_entry_extract() and update_tree_entry()
+ * and returns true for success
+ */
int tree_entry(struct tree_desc *, struct name_entry *);
void *fill_tree_descriptor(struct tree_desc *desc, const unsigned char *sha1);
--
1.7.2.2.39.gf7e23
next prev parent reply other threads:[~2010-08-25 2:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 2:53 [PATCH 0/7] Minor bug fix and optimizations for revision/tree walking Elijah Newren
2010-08-25 2:53 ` [PATCH 1/7] Add testcase showing how pathspecs are ignored with rev-list --objects Elijah Newren
2010-08-25 2:53 ` [PATCH 2/7] Fix ignoring of pathspecs " Elijah Newren
2010-08-25 22:11 ` Nguyen Thai Ngoc Duy
2010-08-25 23:50 ` Elijah Newren
2010-08-26 2:49 ` Elijah Newren
2010-08-26 23:15 ` Nguyen Thai Ngoc Duy
2010-08-26 23:41 ` Junio C Hamano
2010-08-25 2:53 ` Elijah Newren [this message]
2010-08-25 2:53 ` [PATCH 4/7] tree_entry_interesting(): Make return value more specific Elijah Newren
2010-08-25 2:53 ` [PATCH 5/7] diff_tree(): Skip skip_uninteresting() when all remaining paths interesting Elijah Newren
2010-08-25 23:25 ` Junio C Hamano
2010-08-25 23:57 ` Elijah Newren
2010-08-26 3:49 ` Junio C Hamano
2010-08-25 2:53 ` [PATCH 6/7] list-objects.c: Avoid recomputing interesting-ness for subtrees when possible Elijah Newren
2010-08-25 2:53 ` [PATCH 7/7] tree-diff.c: " Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282704795-29661-4-git-send-email-newren@gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).