git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Elijah Newren <newren@gmail.com>
Subject: [PATCH 4/7] tree_entry_interesting(): Make return value more specific
Date: Tue, 24 Aug 2010 20:53:12 -0600	[thread overview]
Message-ID: <1282704795-29661-5-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1282704795-29661-1-git-send-email-newren@gmail.com>

tree_entry_interesting() can signal to its callers not only if the given
entry matches one of the specified paths, but whether all remaining paths
will (or will not) match.  When no paths are specified, all paths are
considered interesting, so intead of returning 1 (this path is interesting)
return 2 (all paths are interesting).

This will allow the caller to avoid calling tree_entry_interesting() again,
which theoretically should speed up tree walking.  I am not able to measure
any actual gains in practice, but it certainly can not hurt and makes more
sense to me.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 tree-diff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tree-diff.c b/tree-diff.c
index 2fb670b..a740a9c 100644
--- a/tree-diff.c
+++ b/tree-diff.c
@@ -101,7 +101,7 @@ int tree_entry_interesting(struct tree_desc *desc, const char *base, int baselen
 	int never_interesting = -1;
 
 	if (!opt->nr_paths)
-		return 1;
+		return 2;
 
 	sha1 = tree_entry_extract(desc, &path, &mode);
 
-- 
1.7.2.2.39.gf7e23

  parent reply	other threads:[~2010-08-25  2:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  2:53 [PATCH 0/7] Minor bug fix and optimizations for revision/tree walking Elijah Newren
2010-08-25  2:53 ` [PATCH 1/7] Add testcase showing how pathspecs are ignored with rev-list --objects Elijah Newren
2010-08-25  2:53 ` [PATCH 2/7] Fix ignoring of pathspecs " Elijah Newren
2010-08-25 22:11   ` Nguyen Thai Ngoc Duy
2010-08-25 23:50     ` Elijah Newren
2010-08-26  2:49       ` Elijah Newren
2010-08-26 23:15       ` Nguyen Thai Ngoc Duy
2010-08-26 23:41         ` Junio C Hamano
2010-08-25  2:53 ` [PATCH 3/7] tree-walk: Correct bitrotted comment about tree_entry() Elijah Newren
2010-08-25  2:53 ` Elijah Newren [this message]
2010-08-25  2:53 ` [PATCH 5/7] diff_tree(): Skip skip_uninteresting() when all remaining paths interesting Elijah Newren
2010-08-25 23:25   ` Junio C Hamano
2010-08-25 23:57     ` Elijah Newren
2010-08-26  3:49       ` Junio C Hamano
2010-08-25  2:53 ` [PATCH 6/7] list-objects.c: Avoid recomputing interesting-ness for subtrees when possible Elijah Newren
2010-08-25  2:53 ` [PATCH 7/7] tree-diff.c: " Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282704795-29661-5-git-send-email-newren@gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).