git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, pclouds@gmail.com, Elijah Newren <newren@gmail.com>
Subject: [PATCHv2 3/8] Document pre-condition for tree_entry_interesting
Date: Thu, 26 Aug 2010 00:21:46 -0600	[thread overview]
Message-ID: <1282803711-10253-4-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1282803711-10253-1-git-send-email-newren@gmail.com>

tree_entry_interesting will fail to find appropriate matches if the base
directory path is not terminated with a slash.  Knowing this earlier would
have saved me some debugging time.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 tree-diff.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tree-diff.c b/tree-diff.c
index 2fb670b..75b1480 100644
--- a/tree-diff.c
+++ b/tree-diff.c
@@ -85,6 +85,8 @@ static int compare_tree_entry(struct tree_desc *t1, struct tree_desc *t2, const
 /*
  * Is a tree entry interesting given the pathspec we have?
  *
+ * Pre-condition: baselen == 0 || base[baselen-1] == '/'
+ *
  * Return:
  *  - 2 for "yes, and all subsequent entries will be"
  *  - 1 for yes
-- 
1.7.2.2.45.ga60f

  parent reply	other threads:[~2010-08-26  6:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  6:21 [PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations Elijah Newren
2010-08-26  6:21 ` [PATCHv2 1/8] Add testcases showing how pathspecs are ignored with rev-list --objects Elijah Newren
2010-08-26  6:21 ` [PATCHv2 2/8] Make rev-list --objects work together with pathspecs Elijah Newren
2010-08-26  6:21 ` Elijah Newren [this message]
2010-08-26  6:21 ` [PATCHv2 4/8] tree-walk: Correct bitrotted comment about tree_entry() Elijah Newren
2010-08-26  6:21 ` [PATCHv2 5/8] tree_entry_interesting(): Make return value more specific Elijah Newren
2010-08-26  6:21 ` [PATCHv2 6/8] diff_tree(): Skip skip_uninteresting() when all remaining paths interesting Elijah Newren
2010-08-26  6:21 ` [PATCHv2 7/8] list-objects.c: Avoid recomputing interesting-ness for subtrees when possible Elijah Newren
2010-08-26  6:21 ` [PATCHv2 8/8] tree-diff.c: " Elijah Newren
2010-08-27 17:28 ` [PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282803711-10253-4-git-send-email-newren@gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).