From: Ramana Kumar <ramana.kumar@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Ramana Kumar <ramana.kumar@gmail.com>
Subject: [PATCH] Make commit help text more accurate for --verbose
Date: Sun, 5 Sep 2010 19:53:03 +1000 [thread overview]
Message-ID: <1283680383-12495-1-git-send-email-ramana.kumar@gmail.com> (raw)
Commit message help text says lines starting with '#' will be ignored.
The diff lines added by --verbose are also ignored, although they don't
start with '#'s. Extend help text to describe behavior on diff lines
when relevant.
Signed-off-by: Ramana Kumar <ramana.kumar@gmail.com>
---
builtin/commit.c | 25 ++++++++++++++++++-------
1 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 66fdd22..b49fd7a 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -658,17 +658,28 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
fprintf(fp,
"\n"
"# Please enter the commit message for your changes.");
- if (cleanup_mode == CLEANUP_ALL)
+ if (cleanup_mode == CLEANUP_ALL && !verbose)
fprintf(fp,
" Lines starting\n"
"# with '#' will be ignored, and an empty"
" message aborts the commit.\n");
- else /* CLEANUP_SPACE, that is. */
- fprintf(fp,
- " Lines starting\n"
- "# with '#' will be kept; you may remove them"
- " yourself if you want to.\n"
- "# An empty message aborts the commit.\n");
+ else {
+ if (cleanup_mode == CLEANUP_ALL)
+ fprintf(fp,
+ " Lines starting\n"
+ "# with '#' will be ignored, as will"
+ " the diff and anything below it.\n");
+ else { /* CLEANUP_SPACE, that is. */
+ fprintf(fp,
+ " Lines starting\n"
+ "# with '#' will be kept; you may remove them"
+ " yourself if you want to.\n");
+ if (verbose)
+ fprintf(fp,
+ "# The diff and anything below it will be ignored.\n");
+ }
+ fprintf(fp, "# An empty message aborts the commit.\n");
+ }
if (only_include_assumed)
fprintf(fp, "# %s\n", only_include_assumed);
--
1.7.2.2
next reply other threads:[~2010-09-05 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 9:53 Ramana Kumar [this message]
2010-09-05 15:06 ` [PATCH] Make commit help text more accurate for --verbose Thiago Farina
2010-09-05 16:30 ` Ævar Arnfjörð Bjarmason
2010-09-14 9:08 ` Ramana Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283680383-12495-1-git-send-email-ramana.kumar@gmail.com \
--to=ramana.kumar@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).