From: Thiago Farina <tfransosi@gmail.com>
To: git@vger.kernel.org
Cc: jrnieder@gmail.com, Thiago Farina <tfransosi@gmail.com>
Subject: [Patch v3] string-list: Document STRING_LIST_INIT_* macros.
Date: Sun, 5 Sep 2010 21:13:11 -0300 [thread overview]
Message-ID: <1283731991-15080-1-git-send-email-tfransosi@gmail.com> (raw)
Clarify the modern ways to initialize a string_list. Text roughly
based on the analogous passage from api-strbuf.txt.
(Note: Based on the demo patch of Jonathan Nieder).
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
Documentation/technical/api-string-list.txt | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/Documentation/technical/api-string-list.txt b/Documentation/technical/api-string-list.txt
index 3f575bd..f689163 100644
--- a/Documentation/technical/api-string-list.txt
+++ b/Documentation/technical/api-string-list.txt
@@ -11,10 +11,15 @@ The caller:
. Allocates and clears a `struct string_list` variable.
-. Initializes the members. You might want to set the flag `strdup_strings`
- if the strings should be strdup()ed. For example, this is necessary
- when you add something like git_path("..."), since that function returns
- a static buffer that will change with the next call to git_path().
+. Initializes the members. A string_list might be initialize by
+ `= STRING_LIST_INT_NODUP` or `= STRING_LIST_INIT_DUP` before it can be used.
+
+ Strings in lists initialized with the _DUP variant will be
+ automatically strdup()ed on insertion and free()ed on removal.
+ For example, this is necessary when you add something like
+ git_path("..."), since that function returns a static buffer
+ that will change with the next call to git_path().
+
+
If you need something advanced, you can manually malloc() the `items`
member (you need this if you add things later) and you should set the
@@ -34,10 +39,9 @@ member (you need this if you add things later) and you should set the
Example:
----
-struct string_list list;
+struct string_list list = STRING_LIST_DUP;
int i;
-memset(&list, 0, sizeof(struct string_list));
string_list_append(&list, "foo");
string_list_append(&list, "bar");
for (i = 0; i < list.nr; i++)
--
1.7.2.3.313.gcd15
next reply other threads:[~2010-09-06 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 0:13 Thiago Farina [this message]
2010-09-06 0:22 ` [Patch v3] string-list: Document STRING_LIST_INIT_* macros Jonathan Nieder
2010-09-06 0:38 ` Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283731991-15080-1-git-send-email-tfransosi@gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).