[PATCH] builtin/clean.c: Use STRING_LIST_INIT

git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.
@ 2010-09-06 23:32 Thiago Farina
  2010-09-06 23:56 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Thiago Farina @ 2010-09-06 23:32 UTC (permalink / raw)
  To: git; +Cc: gitster

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 builtin/clean.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin/clean.c b/builtin/clean.c
index b508d2c..c8798f5 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -44,7 +44,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
 	struct dir_struct dir;
 	static const char **pathspec;
 	struct strbuf buf = STRBUF_INIT;
-	struct string_list exclude_list = { NULL, 0, 0, 0 };
+	struct string_list exclude_list = STRING_LIST_INIT_NODUP;
 	const char *qname;
 	char *seen = NULL;
 	struct option options[] = {
-- 
1.7.2.3.313.gcd15

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.
  2010-09-06 23:32 [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP Thiago Farina
@ 2010-09-06 23:56 ` Junio C Hamano
  2010-09-07  0:03   ` Thiago Farina
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2010-09-06 23:56 UTC (permalink / raw)
  To: Thiago Farina; +Cc: git

Good eyes.  Is this the last spelled-out initialization (I didn't check
deeper than running a quick grep for "struct string_list .*= *{")?

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.
  2010-09-06 23:56 ` Junio C Hamano
@ 2010-09-07  0:03   ` Thiago Farina
  0 siblings, 0 replies; 3+ messages in thread
From: Thiago Farina @ 2010-09-07  0:03 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Mon, Sep 6, 2010 at 8:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Good eyes.  Is this the last spelled-out initialization (I didn't check
> deeper than running a quick grep for "struct string_list .*= *{")?
>
Yup! This is the last. :)

I checked firstly with:
$ git grep -e 'struct string_list [^ ]* = {.*'

And then with yours:
$ git grep -e "struct string_list .*= *{"

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-09-07  0:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-06 23:32 [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP Thiago Farina
2010-09-06 23:56 ` Junio C Hamano
2010-09-07  0:03   ` Thiago Farina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).