git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: davi.reis@gmail.com
To: git@vger.kernel.org
Cc: Davi Reis <davi@dhcp-172-19-8-195.mtv.corp.google.com>
Subject: [PATCH 2/2] Added test from David Glasser.
Date: Thu,  9 Sep 2010 11:21:54 -0700	[thread overview]
Message-ID: <1284056514-4935-2-git-send-email-davi.reis@gmail.com> (raw)
In-Reply-To: <1284056514-4935-1-git-send-email-davi.reis@gmail.com>

From: Davi Reis <davi@dhcp-172-19-8-195.mtv.corp.google.com>

---
 builtin/ls-tree.c           |    2 +-
 t/t3100-ls-tree-restrict.sh |    9 +++++++++
 2 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
index fa427e2..37920d0 100644
--- a/builtin/ls-tree.c
+++ b/builtin/ls-tree.c
@@ -52,7 +52,7 @@ static int show_recursive(const char *base, int baselen, const char *pathname)
 		speclen = strlen(spec);
 		if (speclen <= len)
 			continue;
-		if (spec[len] != 0 && spec[len] != '/')
+		if (spec[len] != '/')
 			continue;
 		if (memcmp(pathname, spec, len))
 			continue;
diff --git a/t/t3100-ls-tree-restrict.sh b/t/t3100-ls-tree-restrict.sh
index eee0d34..9dd74b5 100755
--- a/t/t3100-ls-tree-restrict.sh
+++ b/t/t3100-ls-tree-restrict.sh
@@ -165,4 +165,13 @@ test_expect_success \
 EOF
      test_output'
 
+test_expect_success \
+    'ls-tree with one path a prefix of the other' \
+    'git ls-tree $tree path2/baz path2/bazbo >current &&
+     make_expected <<\EOF &&
+040000 tree X  path2/baz
+120000 blob X  path2/bazbo
+EOF
+     test_output'
+
 test_done
-- 
1.7.2.2

  reply	other threads:[~2010-09-09 18:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 18:21 [PATCH 1/2] Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list davi.reis
2010-09-09 18:21 ` davi.reis [this message]
2010-09-09 21:33   ` [PATCH 2/2] Added test from David Glasser Matthieu Moy
2010-09-09 21:44     ` Davi Reis
2010-09-09 21:30 ` [PATCH 1/2] Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284056514-4935-2-git-send-email-davi.reis@gmail.com \
    --to=davi.reis@gmail.com \
    --cc=davi@dhcp-172-19-8-195.mtv.corp.google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).