From: Chris Packham <judge.packham@gmail.com>
To: git@vger.kernel.org
Subject: [RFC PATCH 0/2] submodule aware grep
Date: Thu, 23 Sep 2010 14:17:05 -0700 [thread overview]
Message-ID: <1285276627-7907-1-git-send-email-judge.packham@gmail.com> (raw)
This series contains 2 RFC patches that both implement a grep feature for
submodules. The first patch is a self-contained script for contrib that should
work with most current git versions. The 2nd is basically the same
implementation but done as a proper git submodule command with some of the
helper code moved to git-sh-setup.sh
There are a couple of questions for this. Technically I'm making submodule
grep-aware, should I be making grep submodule-aware instead? I haven't looked
at the grep code yet but I imagine its harder.
Should I be putting the submodule_root* routines in git-sh-setup or should I be
looking at adding it to 'git rev parse' instead. I'm guessing eventually more
commands might want to be able to get at the base superproject.
Chris Packham (2):
contrib: add git-submodule-grep.sh
submodule: add grep command
next reply other threads:[~2010-09-23 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 21:17 Chris Packham [this message]
2010-09-23 21:17 ` [RFC PATCH 1/2] contrib: add git-submodule-grep.sh Chris Packham
2010-09-23 21:17 ` [RFC PATCH 2/2] submodule: add grep command Chris Packham
2010-09-24 13:47 ` [RFC PATCH 0/2] submodule aware grep Heiko Voigt
2010-09-24 16:07 ` Chris Packham
2010-09-24 17:10 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285276627-7907-1-git-send-email-judge.packham@gmail.com \
--to=judge.packham@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).