From: Elijah Newren <newren@gmail.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>
Subject: [RFC PATCHv2 03/16] t1001 (read-tree-m-2way): add missing &&
Date: Fri, 24 Sep 2010 16:22:43 -0600 [thread overview]
Message-ID: <1285366976-22216-4-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1285366976-22216-1-git-send-email-newren@gmail.com>
FIXME: Is it okay to replace the "|| return 1" with "&&" as I did?
Signed-off-by: Elijah Newren <newren@gmail.com>
---
t/t1001-read-tree-m-2way.sh | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/t/t1001-read-tree-m-2way.sh b/t/t1001-read-tree-m-2way.sh
index 93ca84f..ce8112c 100755
--- a/t/t1001-read-tree-m-2way.sh
+++ b/t/t1001-read-tree-m-2way.sh
@@ -98,8 +98,8 @@ test_expect_success \
git checkout-index -u -f -q -a &&
git update-index --add yomin &&
read_tree_twoway $treeH $treeM &&
- git ls-files --stage >4.out || return 1
- git diff --no-index M.out 4.out >4diff.out
+ git ls-files --stage >4.out &&
+ test_might_fail git diff --no-index M.out 4.out >4diff.out &&
compare_change 4diff.out expected &&
check_cache_at yomin clean'
@@ -112,8 +112,8 @@ test_expect_success \
git update-index --add yomin &&
echo yomin yomin >yomin &&
read_tree_twoway $treeH $treeM &&
- git ls-files --stage >5.out || return 1
- git diff --no-index M.out 5.out >5diff.out
+ git ls-files --stage >5.out &&
+ test_might_fail git diff --no-index M.out 5.out >5diff.out &&
compare_change 5diff.out expected &&
check_cache_at yomin dirty'
@@ -213,8 +213,8 @@ test_expect_success \
echo nitfol nitfol >nitfol &&
git update-index --add nitfol &&
read_tree_twoway $treeH $treeM &&
- git ls-files --stage >14.out || return 1
- git diff --no-index M.out 14.out >14diff.out
+ git ls-files --stage >14.out &&
+ test_might_fail git diff --no-index M.out 14.out >14diff.out &&
compare_change 14diff.out expected &&
check_cache_at nitfol clean'
@@ -227,8 +227,8 @@ test_expect_success \
git update-index --add nitfol &&
echo nitfol nitfol nitfol >nitfol &&
read_tree_twoway $treeH $treeM &&
- git ls-files --stage >15.out || return 1
- git diff --no-index M.out 15.out >15diff.out
+ git ls-files --stage >15.out &&
+ test_might_fail git diff --no-index M.out 15.out >15diff.out &&
compare_change 15diff.out expected &&
check_cache_at nitfol dirty'
@@ -377,7 +377,7 @@ test_expect_success \
git ls-files --stage >treeM.out &&
rm -f a &&
- mkdir a
+ mkdir a &&
: >a/b &&
git update-index --add --remove a a/b &&
treeH=`git write-tree` &&
--
1.7.3.95.g14291
next prev parent reply other threads:[~2010-09-24 22:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 22:22 [RFC PATCHv2 00/16] Add missing &&'s in the testsuite Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 01/16] t3020 (ls-files-error-unmatch): remove stray '1' from end of file Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 02/16] t4017 (diff-retval): replace manual exit code check with test_expect_code Elijah Newren
2010-09-24 22:49 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` Elijah Newren [this message]
2010-09-24 22:50 ` [RFC PATCHv2 03/16] t1001 (read-tree-m-2way): add missing && Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 04/16] t1002 (read-tree-m-u-2way): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 05/16] t4002 (diff-basic): use test_might_fail for commands that might fail Elijah Newren
2010-09-24 22:52 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 06/16] t4202 (log): Replace '<git-command> || :' with test_might_fail Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 07/16] t3600 (rm): add lots of missing && Elijah Newren
2010-09-24 22:58 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 08/16] t4019 (diff-wserror): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 09/16] t4026 (color): add " Elijah Newren
2010-09-24 22:55 ` Ævar Arnfjörð Bjarmason
2010-09-25 4:02 ` Jeff King
2010-09-25 7:56 ` Jakub Narebski
2010-09-24 22:22 ` [RFC PATCHv2 10/16] t5602 (clone-remote-exec): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 11/16] t6016 (rev-list-graph-simplify-history): " Elijah Newren
2010-09-24 23:00 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 12/16] t6050 (replace): " Elijah Newren
2010-09-24 23:04 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 13/16] t7001 (mv): " Elijah Newren
2010-09-24 23:00 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 14/16] t7601 (merge-pull-config): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 15/16] t7800 (difftool): " Elijah Newren
2010-09-24 23:02 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 16/16] Add missing &&'s throughout the testsuite Elijah Newren
2010-09-24 23:18 ` Ævar Arnfjörð Bjarmason
2010-09-25 16:50 ` Elijah Newren
2010-09-25 17:05 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285366976-22216-4-git-send-email-newren@gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).