From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org, robbat2@gentoo.org, casey@nrlssc.navy.mil,
avarab@gmail.com
Cc: Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v4 0/4] rev-parse: allow --flags to output rev-parse-like flags
Date: Sat, 25 Sep 2010 23:33:49 +1000 [thread overview]
Message-ID: <1285421633-22684-1-git-send-email-jon.seymour@gmail.com> (raw)
This series allows git rev-parse --flags to output remaining flag-like arguments
even if such arguments are valid options to git rev-parse itself.
Previously:
$ git rev-parse --flags -q -X --no-flags -- Y -Z
-X
$
Now:
$ git rev-parse --flags -q -X --no-flags -- Y -Z
-q -X --no-flags
$
This series also changes the interpretation of --flags so that
specification of this option implies --no-revs.
Previously:
$ git rev-parse --flags HEAD
HEAD
$
Now:
$ git rev-parse --flags HEAD
$
Reviewers attention is drawn to the following behaviour which, while
unchanged from current behaviour, differs from the behaviour specified
by the documentation. Specifically:
$ git rev-parse -X --no-flags
-X
$ git rev-parse --no-flags -X
$
In other words, a git rev-parse option only ever affects the
interpretation of succeeding options, never preceding options.
Aevar's feedback on v2 of this series has been incorporated.
Jon Seymour (4):
rev-parse: stop interpreting flags as options to rev-parse once
--flags is specified
rev-parse: add tests for git rev-parse --flags.
rev-parse: update documentation of --flags and --no-flags options
rev-parse: make --flags imply --no-revs for remaining arguments.
Documentation/git-rev-parse.txt | 12 ++++
builtin/rev-parse.c | 14 +++++-
t/t1510-rev-parse-flags.sh | 109 +++++++++++++++++++++++++++++++++++++++
3 files changed, 134 insertions(+), 1 deletions(-)
create mode 100755 t/t1510-rev-parse-flags.sh
--
1.7.3.3.gc4c52.dirty
next reply other threads:[~2010-09-25 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 13:33 Jon Seymour [this message]
2010-09-25 13:33 ` [PATCH v4 1/4] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour
2010-09-25 13:33 ` [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags Jon Seymour
2010-09-25 14:27 ` Ævar Arnfjörð Bjarmason
2010-09-25 16:19 ` Jon Seymour
2010-09-25 13:33 ` [PATCH v4 3/4] rev-parse: update documentation of --flags and --no-flags options Jon Seymour
2010-09-25 13:33 ` [PATCH v4 4/4] rev-parse: make --flags imply --no-revs for remaining arguments Jon Seymour
2010-09-25 14:20 ` Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285421633-22684-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=avarab@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).