git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org, robbat2@gentoo.org, casey@nrlssc.navy.mil,
	avarab@gmail.com, gitster@pobox.com
Cc: Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v7 0/3] rev-parse: allow --flags to output rev-parse-like flags
Date: Mon, 27 Sep 2010 00:44:04 +1000	[thread overview]
Message-ID: <1285512247-15600-1-git-send-email-jon.seymour@gmail.com> (raw)
In-Reply-To: <7v1v8hnflx.fsf@alter.siamese.dyndns.org>

This series allows git rev-parse --flags to output remaining flag-like arguments
even if such arguments are valid options to git rev-parse itself.

Previously:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -X
  $

Now:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -q -X --no-flags
  $

Aevar's feedback on v2 and v4 of this series has been incorporated.

The first commit modifies the documentation so that it accurately
reflects the current implementation.

The second commit introduces tests that document existing behaviour.

The third commit changes the way git rev-parse interprets option-like
arguments after the first --flags option is processed.

The first and second commits should be non-controversial since they
merely document and test existing behaviour. The third commit
is offered for discussion.

v7 removes the patch that made --flags imply --no-revs.

Jon Seymour (3):
  rev-parse: update Documentation of --flags
  rev-parse: add tests for git rev-parse --flags.
  rev-parse: stop interpreting flags as options to rev-parse once
    --flags is specified

 Documentation/git-rev-parse.txt |   12 +++-
 builtin/rev-parse.c             |    8 ++
 t/t1510-rev-parse-flags.sh      |  172 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 191 insertions(+), 1 deletions(-)
 create mode 100755 t/t1510-rev-parse-flags.sh

-- 
1.7.3.3.g9129b6

  parent reply	other threads:[~2010-09-26 14:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 19:19 git-1.7.3 breakage: "git stash show xxx" doesn't show anything Robin H. Johnson
2010-09-24 20:01 ` Brandon Casey
2010-09-24 20:27   ` Brian Gernhardt
2010-09-24 20:40     ` [PATCH] t/t3903-stash: improve testing of git-stash show Brandon Casey
2010-09-24 20:43       ` Brian Gernhardt
2010-09-24 20:50         ` Brandon Casey
2010-09-24 21:49           ` Brian Gernhardt
2010-09-24 22:11             ` [PATCH] git-stash: fix flag parsing Brian Gernhardt
2010-09-24 22:15             ` Brian Gernhardt
2010-09-25  2:58               ` Jon Seymour
2010-09-27  4:36               ` Junio C Hamano
2010-09-27 15:32                 ` [PATCH] stash: simplify parsing fixes Jon Seymour
2010-09-25  2:54 ` [PATCH] stash show: fix breakage in 1.7.3 Jon Seymour
2010-09-25  3:32 ` [PATCH v1] " Jon Seymour
2010-09-25  4:45   ` Brian Gernhardt
2010-09-25  6:19     ` Jon Seymour
2010-09-25  7:15   ` Jon Seymour
2010-09-27 15:38   ` Jon Seymour
2010-09-25  7:19 ` [PATCH/RFC] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour
2010-09-25  7:19   ` Jon Seymour
2010-09-25  7:25     ` Jon Seymour
2010-09-26  7:11       ` Junio C Hamano
2010-09-26 14:39         ` Jon Seymour
2010-09-26 14:44         ` Jon Seymour [this message]
2010-09-26 14:44         ` [PATCH v7 1/3] rev-parse: update Documentation of --flags Jon Seymour
2010-09-26 14:44         ` [PATCH v7 2/3] rev-parse: add tests for git rev-parse --flags Jon Seymour
2010-09-26 14:44         ` [PATCH v7 3/3] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285512247-15600-1-git-send-email-jon.seymour@gmail.com \
    --to=jon.seymour@gmail.com \
    --cc=avarab@gmail.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).