From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: johan@herland.net, jrnieder@gmail.com, bebarino@gmail.com,
avarab@gmail.com, gitster@pobox.com
Subject: [PATCHv3 01/21] notes.c: Hexify SHA1 in die() message from init_notes()
Date: Sat, 9 Oct 2010 03:08:28 +0200 [thread overview]
Message-ID: <1286586528-3473-2-git-send-email-johan@herland.net> (raw)
In-Reply-To: <1286586528-3473-1-git-send-email-johan@herland.net>
Signed-off-by: Johan Herland <johan@herland.net>
---
Found this while testing other aspects of this series.
...Johan
notes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notes.c b/notes.c
index 1978244..bb03eb0 100644
--- a/notes.c
+++ b/notes.c
@@ -940,7 +940,7 @@ void init_notes(struct notes_tree *t, const char *notes_ref,
return;
if (get_tree_entry(object_sha1, "", sha1, &mode))
die("Failed to read notes tree referenced by %s (%s)",
- notes_ref, object_sha1);
+ notes_ref, sha1_to_hex(object_sha1));
hashclr(root_tree.key_sha1);
hashcpy(root_tree.val_sha1, sha1);
--
1.7.3.1.104.g92b87a
next prev parent reply other threads:[~2010-10-09 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 1:08 [PATCHv3 00/21] git notes merge Johan Herland
2010-10-09 1:08 ` Johan Herland [this message]
2010-10-09 1:08 ` [PATCHv3 02/21] (trivial) notes.h: Minor documentation fixes to copy_notes() Johan Herland
2010-10-09 1:08 ` [PATCHv3 03/21] notes.h: Make default_notes_ref() available in notes API Johan Herland
2010-10-09 1:08 ` [PATCHv3 04/21] notes.c: Reorder functions in preparation for next commit Johan Herland
2010-10-13 21:59 ` Junio C Hamano
2010-10-13 22:20 ` Jonathan Nieder
2010-10-09 11:28 ` [PATCHv3 00/21] git notes merge Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286586528-3473-2-git-send-email-johan@herland.net \
--to=johan@herland.net \
--cc=avarab@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).