From: stepnem@gmail.com
To: gitster@pobox.com
Cc: git@vger.kernel.org
Subject: [PATCH] CodingGuidelines: Fix a typo
Date: Sat, 9 Oct 2010 13:18:39 +0200 [thread overview]
Message-ID: <1286623119-13766-1-git-send-email-stepnem@gmail.com> (raw)
From: Štěpán Němec <stepnem@gmail.com>
`${parameter/pattern/string}' shell expansion uses glob patterns, so
talking about `regexp' is confusing.
Signed-off-by: Štěpán Němec <stepnem@gmail.com>
---
Documentation/CodingGuidelines | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 8346c19..df50ccf 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -53,7 +53,7 @@ For shell scripts specifically (not exhaustive):
- No strlen ${#parameter}.
- - No regexp ${parameter/pattern/string}.
+ - No substitution ${parameter/pattern/string}.
- We do not use Process Substitution <(list) or >(list).
--
1.7.3.rc2.221.gbf93f.dirty
next reply other threads:[~2010-10-09 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 11:18 stepnem [this message]
2010-10-09 15:27 ` [PATCH] CodingGuidelines: Fix a typo Jonathan Nieder
2010-10-09 17:35 ` Štěpán Němec
2010-10-09 17:51 ` Junio C Hamano
2010-10-11 6:44 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286623119-13766-1-git-send-email-stepnem@gmail.com \
--to=stepnem@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).