From: Kevin Ballard <kevin@sb.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Kevin Ballard <kevin@sb.org>
Subject: [PATCH] Make test script annotate-tests.sh handle missing authors
Date: Fri, 15 Oct 2010 22:50:15 -0700 [thread overview]
Message-ID: <1287208215-91901-1-git-send-email-kevin@sb.org> (raw)
Initialize the %count hash to contain all the expected authors already.
This allows the script to print an error if an expected author was omitted
entirely from the blame/annotate output.
Signed-off-by: Kevin Ballard <kevin@sb.org>
---
I discovered this omission when trying to write a test for a change to
git-blame that I will be submitting shortly. Without this change, if an
author never showed up in the blame output, it would errneously consider
that to be ok. It still ignores authors that were never specified as
expected in the first place, but I wasn't so sure that was an error.
Also, I'm not a Perl programmer, so it's possible there's a better idiom
for this sort of thing.
t/annotate-tests.sh | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index 396b965..4e37a66 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -9,6 +9,9 @@ check_count () {
cat .result | perl -e '
my %expect = (@ARGV);
my %count = ();
+ while (my ($author, $count) = each %expect) {
+ $count{$author} = 0;
+ }
while (<STDIN>) {
if (/^[0-9a-f]+\t\(([^\t]+)\t/) {
my $author = $1;
--
1.7.3.1.186.gc0af9.dirty
next reply other threads:[~2010-10-16 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 5:50 Kevin Ballard [this message]
2010-10-16 7:34 ` [PATCH] Make test script annotate-tests.sh handle missing authors Jakub Narebski
2010-10-16 10:43 ` Kevin Ballard
2010-10-16 11:09 ` [PATCH v2] Update test script annotate-tests.sh to handle missing/extra authors Kevin Ballard
2010-10-16 12:22 ` [PATCH] Make test script annotate-tests.sh handle missing authors Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287208215-91901-1-git-send-email-kevin@sb.org \
--to=kevin@sb.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).