git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marat Radchenko <marat@slonopotamus.org>
To: git@vger.kernel.org
Subject: Re: [BUG] git repack fails if .git/objects/pack is on a separate partition
Date: Tue, 19 Oct 2010 00:29:23 -0700 (PDT)	[thread overview]
Message-ID: <1287473363910-5649843.post@n2.nabble.com> (raw)
In-Reply-To: <201010190859.43098.trast@student.ethz.ch>




> What's your git version?
> 
1.7.3.1



> It should only create and rename
> files within the pack/ subdirectory.
> 
It should, yep, but it doesn't.


Which is what you are implying
> in the above snippet, but this should never result in a cross-device
> rename, so maybe I'm missing something.
> 
That rename call attempts to put file in _current_ directory.

Proof:
mkdir foo && touch foo/bar && strace mv foo/bar baz 2>&1 | grep rename
outputs rename("foo/bar", "baz")


-- 
View this message in context: http://git.661346.n2.nabble.com/BUG-git-repack-fails-if-git-objects-pack-is-on-a-separate-partition-tp5649732p5649843.html
Sent from the git mailing list archive at Nabble.com.

  reply	other threads:[~2010-10-19  7:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  6:28 [BUG] git repack fails if .git/objects/pack is on a separate partition Marat Radchenko
2010-10-19  6:59 ` Thomas Rast
2010-10-19  7:29   ` Marat Radchenko [this message]
2010-10-19  7:40     ` Marat Radchenko
2010-10-19  9:50       ` [PATCH] repack: place temporary packs under .git/objects/pack/ Thomas Rast
2010-10-19 10:17         ` Marat Radchenko
2010-10-19 16:33         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287473363910-5649843.post@n2.nabble.com \
    --to=marat@slonopotamus.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).