From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Gernhardt Subject: [PATCH v2] t/gitweb-lib: Don't pass constant to decode_utf8 Date: Wed, 20 Oct 2010 01:57:11 -0400 Message-ID: <1287554231-84196-1-git-send-email-brian@gernhardtsoftware.com> Cc: Jakub Narebski , Sven Verdoolaege , Junio C Hamano To: Git List X-From: git-owner@vger.kernel.org Wed Oct 20 07:57:28 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P8Rfw-0003EY-4C for gcvg-git-2@lo.gmane.org; Wed, 20 Oct 2010 07:57:24 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755666Ab0JTF5S (ORCPT ); Wed, 20 Oct 2010 01:57:18 -0400 Received: from vs072.rosehosting.com ([216.114.78.72]:45228 "EHLO silverinsanity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab0JTF5S (ORCPT ); Wed, 20 Oct 2010 01:57:18 -0400 Received: by silverinsanity.com (Postfix, from userid 5001) id 687EE1FFC05B; Wed, 20 Oct 2010 05:57:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on silverinsanity.com X-Spam-Level: X-Spam-Status: No, score=-4.5 required=4.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from localhost.localdomain (cpe-74-67-185-155.rochester.res.rr.com [74.67.185.155]) by silverinsanity.com (Postfix) with ESMTPA id E7F261FFC057; Wed, 20 Oct 2010 05:57:02 +0000 (UTC) X-Mailer: git-send-email 1.7.3.1.209.g52408 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Encode.pm started updating the string to decode in-place when a second argument is passed in version 2.40. This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message like: Modification of a read-only value attempted at /Library/Perl/Updates/5.10.0/darwin-thread-multi-2level/Encode.pm line 216. Work around this by passing an empty variable instead of a constant string. Signed-off-by: Brian Gernhardt --- Changes since v1: - Use an explicitly empty variable instead of $_ - Clearer commit message - CC people who worked on t/gitweb-lib.sh - based against maint t/gitweb-lib.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh index 81ef2a0..1b9523d 100644 --- a/t/gitweb-lib.sh +++ b/t/gitweb-lib.sh @@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then test_done fi -perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || { +perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || { skip_all='skipping gitweb tests, perl version is too old' test_done } -- 1.7.3.1.209.g52408