git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [WIP PATCH 00/18] setup tests
@ 2010-10-24 12:11 Nguyễn Thái Ngọc Duy
  2010-10-24 12:11 ` [WIP PATCH 01/18] rev-parse: add --internal-cwd and --internal-git-dir for tests Nguyễn Thái Ngọc Duy
                   ` (17 more replies)
  0 siblings, 18 replies; 23+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2010-10-24 12:11 UTC (permalink / raw)
  To: git; +Cc: Nguyễn Thái Ngọc Duy

These tests are created according to [1] and its following
discussions. I have yet to create tests for the last 16 cases, which
might be simpler.  Tests from 8-15 are usually copy of 0-7 with some
modification. If you find bugs in 0-7, stop reading 8-15, it's just
wasting time.

The rules are bent a bit the way the code does it, specifically:

 - GIT_WORK_TREE is relative to cwd, not GIT_DIR
 - core.worktree is always effective regardless GIT_DIR/--git-dir

Also I assume that when cwd is outside worktree, cwd should be
unchanged (therefore prefix is NULL). This is the behavior when
GIT_DIR and GIT_WORK_TREE are set. Let's apply it to all other cases
where cwd may be outside worktree.

Adjusting the expected results is not hard. So it's up to you guys.
Once we agree on something, I can update the tests.

Also when GIT_DIR is set, .git _file_ is not recognized because
setup_explicit_git_dir() does not accept it. There are a
_lot_ of failed tests due to this. I probably should fix that,
otherwise tests #8-15 may not be very reliable.

[1] http://mid.gmane.org/20101020085859.GA13135@do

Nguyễn Thái Ngọc Duy (18):
  rev-parse: add --internal-cwd and --internal-git-dir for tests
  Add t1510 for setup tests
  t1510: setup case #0
  t1510: setup case #1
  t1510: setup case #2
  t1510: setup case #3
  t1510: setup case #4
  t1510: setup case #5
  t1510: setup case #6
  t1510: setup case #7
  t1510: setup case #8
  t1510: setup case #9
  t1510: setup case #10
  t1510: setup case #11
  t1510: setup case #12
  t1510: setup case #13
  t1510: setup case #14
  t1510: setup case #15

 builtin/rev-parse.c   |   11 +
 t/t1510-repo-setup.sh | 2483 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 2494 insertions(+), 0 deletions(-)
 create mode 100755 t/t1510-repo-setup.sh

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2010-10-25 10:31 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 12:11 [WIP PATCH 00/18] setup tests Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 01/18] rev-parse: add --internal-cwd and --internal-git-dir for tests Nguyễn Thái Ngọc Duy
2010-10-24 15:40   ` Jonathan Nieder
2010-10-25  0:04     ` Nguyen Thai Ngoc Duy
2010-10-25 10:15       ` Jakub Narebski
2010-10-25 10:30         ` Nguyen Thai Ngoc Duy
2010-10-24 12:11 ` [WIP PATCH 02/18] Add t1510 for setup tests Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 03/18] t1510: setup case #0 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 04/18] t1510: setup case #1 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 05/18] t1510: setup case #2 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 06/18] t1510: setup case #3 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 07/18] t1510: setup case #4 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 08/18] t1510: setup case #5 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 09/18] t1510: setup case #6 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 10/18] t1510: setup case #7 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 11/18] t1510: setup case #8 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 12/18] t1510: setup case #9 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 13/18] t1510: setup case #10 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 14/18] t1510: setup case #11 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 15/18] t1510: setup case #12 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 16/18] t1510: setup case #13 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 17/18] t1510: setup case #14 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 18/18] t1510: setup case #15 Nguyễn Thái Ngọc Duy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).