git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pat Notz" <patnotz@gmail.com>
To: git@vger.kernel.org
Subject: [PATCHv7 0/6] Add commit message options for rebase --autosquash
Date: Tue, 2 Nov 2010 13:59:06 -0600	[thread overview]
Message-ID: <1288727952-57498-1-git-send-email-patnotz@gmail.com> (raw)

This patch series adds new command line options to git-commit to make
it easy to specify messages for commits correctly formatted for use
with 'rebase -i --autosquash'.

This iteration (v7) addresses criticisms about implementation details
raised against the v6 series.  For details, see

http://thread.gmane.org/gmane.comp.version-control.git/159547

The first patch introduces minor refactorings that set the stage
for subsequent patches, mostly preventing copy-n-paste coding in what
follows.

The second patch teaches format_commit_message to reencode the content
if the caller's commit object uses an encoding different from the
commit encoding.

The remaining patches add the --fixup and --squash commands to
git-commit including tests of commit, interactions with rebase and
i18n encodings.  

One issue which limits the testing (but not the implementation, I
think) is that when 'rebase --autosquash' is comparing commit subject
lines it does not first make sure that the commits use a common
encoding.  That's follow-on work.

Pat Notz (6):
  commit: helper methods to reduce redundant blocks of code
  pretty.c: teach format_commit_message() to reencode the output
  commit: --fixup option for use with rebase --autosquash
  add tests of commit --fixup
  commit: --squash option for use with rebase --autosquash
  add tests of commit --squash

 Documentation/git-commit.txt |   21 +++++++++--
 builtin/commit.c             |   81 ++++++++++++++++++++++++++++--------------
 builtin/log.c                |    3 +-
 builtin/mailinfo.c           |    2 +-
 cache.h                      |    3 ++
 commit.c                     |   13 +++++++
 commit.h                     |    4 ++
 environment.c                |   11 ++++++
 pretty.c                     |   36 ++++++++++++-------
 t/t3415-rebase-autosquash.sh |   29 ++++++++++++++-
 t/t3900-i18n-commit.sh       |   29 +++++++++++++++
 t/t7500-commit.sh            |   80 +++++++++++++++++++++++++++++++++++++++++
 t/t7500/edit-content         |    4 ++
 13 files changed, 267 insertions(+), 49 deletions(-)
 create mode 100755 t/t7500/edit-content

-- 
1.7.3.2

             reply	other threads:[~2010-11-02 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 19:59 Pat Notz [this message]
2010-11-02 19:59 ` [PATCHv7 1/6] commit: helper methods to reduce redundant blocks of code Pat Notz
2010-11-02 20:42   ` Thiago Farina
2010-11-02 19:59 ` [PATCHv7 2/6] pretty.c: teach format_commit_message() to reencode the output Pat Notz
2010-11-02 19:59 ` [PATCHv7 3/6] commit: --fixup option for use with rebase --autosquash Pat Notz
2010-11-02 19:59 ` [PATCHv7 4/6] add tests of commit --fixup Pat Notz
2010-11-02 19:59 ` [PATCHv7 5/6] commit: --squash option for use with rebase --autosquash Pat Notz
2010-11-03  9:20   ` Stephen Boyd
2010-11-02 19:59 ` [PATCHv7 6/6] add tests of commit --squash Pat Notz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288727952-57498-1-git-send-email-patnotz@gmail.com \
    --to=patnotz@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).