From: Yann Dirson <ydirson@altern.org>
To: git@vger.kernel.org
Cc: Yann Dirson <ydirson@altern.org>
Subject: [PATCH v2 3/3] [RFC] Add a sorted-list API for use-cases that require to get the element index.
Date: Sat, 6 Nov 2010 22:00:35 +0100 [thread overview]
Message-ID: <1289077235-3208-4-git-send-email-ydirson@altern.org> (raw)
In-Reply-To: <1289077235-3208-1-git-send-email-ydirson@altern.org>
The idea was to replace index_name_pos(), but that would require a much
larger API change in callers.
Signed-off-by: Yann Dirson <ydirson@altern.org>
---
sorted-array.h | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/sorted-array.h b/sorted-array.h
index 03d5d1e..df07687 100644
--- a/sorted-array.h
+++ b/sorted-array.h
@@ -1,7 +1,7 @@
#define declare_sorted_array(MAYBESTATIC,ELEMTYPE,LIST,CMP,INIT) \
MAYBESTATIC ELEMTYPE *LIST; \
MAYBESTATIC int LIST##_nr, LIST##_alloc; \
-MAYBESTATIC ELEMTYPE *locate_##LIST(void *data, int insert_ok) \
+MAYBESTATIC int locate_##LIST##_idx(void *data, int insert_ok) \
{ \
int first, last; \
\
@@ -12,7 +12,7 @@ MAYBESTATIC ELEMTYPE *locate_##LIST(void *data, int insert_ok) \
ELEMTYPE *nextelem = &(LIST[next]); \
int cmp = CMP(data, nextelem); \
if (!cmp) \
- return nextelem; \
+ return next; \
if (cmp < 0) { \
last = next; \
continue; \
@@ -21,7 +21,7 @@ MAYBESTATIC ELEMTYPE *locate_##LIST(void *data, int insert_ok) \
} \
/* not found */ \
if (!insert_ok) \
- return NULL; \
+ return -first-1; \
/* insert to make it at "first" */ \
if (LIST##_alloc <= LIST##_nr) { \
LIST##_alloc = alloc_nr(LIST##_alloc); \
@@ -32,5 +32,12 @@ MAYBESTATIC ELEMTYPE *locate_##LIST(void *data, int insert_ok) \
memmove(LIST + first + 1, LIST + first, \
(LIST##_nr - first - 1) * sizeof(*LIST)); \
INIT(&LIST[first], data); \
- return &(LIST[first]); \
+ return first; \
+} \
+MAYBESTATIC ELEMTYPE *locate_##LIST(void *data, int insert_ok) \
+{ \
+ int idx = locate_##LIST##_idx(data, insert_ok); \
+ if (idx < 0) \
+ return NULL; \
+ return &(LIST[idx]); \
}
--
1.7.2.3
prev parent reply other threads:[~2010-11-06 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 21:00 [PATCH v2] generalizing sorted-array handling Yann Dirson
2010-11-06 21:00 ` [PATCH v2 1/3] Introduce sorted-array binary-search function Yann Dirson
2010-11-06 21:00 ` [PATCH v2 2/3] Convert diffcore-rename's rename_src to the new sorted-array API Yann Dirson
2010-11-06 21:00 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289077235-3208-4-git-send-email-ydirson@altern.org \
--to=ydirson@altern.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).