* [PATCH] rebase: only show stat if configured to true
@ 2010-11-09 20:59 Martin von Zweigbergk
2010-11-29 22:50 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Martin von Zweigbergk @ 2010-11-09 20:59 UTC (permalink / raw)
To: git, gitster; +Cc: Martin von Zweigbergk
If rebase.stat is set to true, a diffstat should be displayed. If it is
not set, it should default to false. However, if it is explicitly set to
false (or other value), a diffstat is still displayed, which is probably
not what most users would expect. Show diffstat only if it is set
to true.
Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
---
git-rebase.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index e5df23b..42c0628 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -49,7 +49,8 @@ do_merge=
dotest="$GIT_DIR"/rebase-merge
prec=4
verbose=
-diffstat=$(git config --bool rebase.stat)
+diffstat=
+test "$(git config --bool rebase.stat)" = true && diffstat=t
git_am_opt=
rebase_root=
force_rebase=
--
1.7.3.2.167.ga361b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rebase: only show stat if configured to true
2010-11-09 20:59 [PATCH] rebase: only show stat if configured to true Martin von Zweigbergk
@ 2010-11-29 22:50 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2010-11-29 22:50 UTC (permalink / raw)
To: Martin von Zweigbergk; +Cc: git
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
> If rebase.stat is set to true, a diffstat should be displayed. If it is
> not set, it should default to false. However, if it is explicitly set to
> false (or other value), a diffstat is still displayed, which is probably
> not what most users would expect. Show diffstat only if it is set
> to true.
>
> Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
> ---
Sounds sensible; it would have been nicer if it came with a test, but this
particular change is sort of obvious ;-)
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-29 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 20:59 [PATCH] rebase: only show stat if configured to true Martin von Zweigbergk
2010-11-29 22:50 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).