From: David Fries <david@Fries.net>
To: git@vger.kernel.org
Cc: David Fries <David@Fries.net>
Subject: [PATCH 2/3] gitk: improve dark background, use diffcolor 2 for link
Date: Wed, 10 Nov 2010 23:19:01 -0600 [thread overview]
Message-ID: <1289452742-7235-2-git-send-email-david@fries.net> (raw)
In-Reply-To: <1289451597-6950-1-git-send-email-david@fries.net>
blue on a black background might as well look like dark blue on black
and is very difficult to read. The "Diff: hunk header" keeps the
colors more consistent and both default to blue.
Signed-off-by: David Fries <David@Fries.net>
---
gitk-git/gitk | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index af43353..bef2e53 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -6673,7 +6673,7 @@ proc appendwithlinks {text tags} {
}
proc setlink {id lk} {
- global curview ctext pendinglinks
+ global curview ctext pendinglinks diffcolors
set known 0
if {[string length $id] < 40} {
@@ -6687,7 +6687,7 @@ proc setlink {id lk} {
set known [commitinview $id $curview]
}
if {$known} {
- $ctext tag conf $lk -foreground blue -underline 1
+ $ctext tag conf $lk -foreground [lindex $diffcolors 2] -underline 1
$ctext tag bind $lk <1> [list selbyid $id]
$ctext tag bind $lk <Enter> {linkcursor %W 1}
$ctext tag bind $lk <Leave> {linkcursor %W -1}
@@ -10792,8 +10792,7 @@ proc doprefs {} {
label $top.hunksep -padx 40 -relief sunk -background [lindex $diffcolors 2]
${NS}::button $top.hunksepbut -text [mc "Diff: hunk header"] \
-command [list choosecolor diffcolors 2 $top.hunksep \
- [mc "diff hunk header"] \
- [list $ctext tag conf hunksep -foreground]]
+ [mc "diff hunk header"] sethunksep ]
grid x $top.hunksepbut $top.hunksep -sticky w
label $top.markbgsep -padx 40 -relief sunk -background $markbgcolor
${NS}::button $top.markbgbut -text [mc "Marked line bg"] \
@@ -10890,6 +10889,19 @@ proc setfg {c} {
$canv itemconf line -fill $c
}
+# update hunksep and each link foreground color
+proc sethunksep {c} {
+ global ctext linknum
+
+ $ctext tag conf hunksep -foreground $c
+ for {set i 0} {$i < $linknum} {incr i} {
+ # Use -underline to determine if it is a known link and gets this color
+ if {[$ctext tag cget link$i -underline] != ""} {
+ $ctext tag conf link$i -foreground $c
+ }
+ }
+}
+
proc prefscan {} {
global oldprefs prefstop
--
1.7.2.3
next prev parent reply other threads:[~2010-11-11 5:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 4:59 [PATCH 0/3] gitk: improve dark background David Fries
2010-11-11 5:19 ` [PATCH 1/3] gitk: improve dark background, s/black/$fgcolor/ David Fries
2010-11-11 5:19 ` David Fries [this message]
2010-11-11 5:19 ` [PATCH 3/3] gitk: improve dark background, select light or dark tags David Fries
2010-11-26 22:41 ` [PATCH 0/3] gitk: improve dark background David Fries
2010-11-27 1:34 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2010-07-22 23:12 [PATCH 2/3] gitk: improve dark background, use diffcolor 2 for link David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289452742-7235-2-git-send-email-david@fries.net \
--to=david@fries.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).