git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCHv7 05/11] gitweb: nagivation menu for tags, heads and remotes
Date: Thu, 11 Nov 2010 13:26:12 +0100	[thread overview]
Message-ID: <1289478378-15604-6-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <1289478378-15604-1-git-send-email-giuseppe.bilotta@gmail.com>

tags, heads and remotes are all views that inspect a (particular class
of) refs, so allow the user to easily switch between them by adding
the appropriate navigation submenu to each view.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9fcbbb2..7cd50d4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3733,6 +3733,19 @@ sub git_print_page_nav {
 	      "</div>\n";
 }
 
+# returns a submenu for the nagivation of the refs views (tags, heads,
+# remotes) with the current view disabled and the remotes view only
+# available if the feature is enabled
+sub format_ref_views {
+	my ($current) = @_;
+	my @ref_views = qw{tags heads};
+	push @ref_views, 'remotes' if gitweb_check_feature('remote_heads');
+	return join " | ", map {
+		$_ eq $current ? $_ :
+		$cgi->a({-href => href(action=>$_)}, $_)
+	} @ref_views
+}
+
 sub format_paging_nav {
 	my ($action, $page, $has_next_link) = @_;
 	my $paging_nav;
@@ -5509,7 +5522,7 @@ sub git_blame_data {
 sub git_tags {
 	my $head = git_get_head_hash($project);
 	git_header_html();
-	git_print_page_nav('','', $head,undef,$head);
+	git_print_page_nav('','', $head,undef,$head,format_ref_views('tags'));
 	git_print_header_div('summary', $project);
 
 	my @tagslist = git_get_tags_list();
@@ -5522,7 +5535,7 @@ sub git_tags {
 sub git_heads {
 	my $head = git_get_head_hash($project);
 	git_header_html();
-	git_print_page_nav('','', $head,undef,$head);
+	git_print_page_nav('','', $head,undef,$head,format_ref_views('heads'));
 	git_print_header_div('summary', $project);
 
 	my @headslist = git_get_heads_list();
@@ -5538,7 +5551,7 @@ sub git_remotes {
 
 	my $head = git_get_head_hash($project);
 	git_header_html();
-	git_print_page_nav('','', $head,undef,$head);
+	git_print_page_nav('','', $head,undef,$head,format_ref_views('remotes'));
 	git_print_header_div('summary', $project);
 
 	my @remotelist = git_get_heads_list(undef, 'remotes');
-- 
1.7.3.68.g6ec8

  parent reply	other threads:[~2010-11-11 12:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 12:26 [PATCHv7 00/11] gitweb: remote_heads feature Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 01/11] gitweb: use fullname as hash_base in heads link Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 02/11] gitweb: introduce remote_heads feature Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 03/11] gitweb: git_get_heads_list accepts an optional list of refs Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 04/11] gitweb: separate heads and remotes lists Giuseppe Bilotta
2010-11-11 12:26 ` Giuseppe Bilotta [this message]
2010-11-11 12:26 ` [PATCHv7 06/11] gitweb: allow action specialization in page header Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 07/11] gitweb: remotes view for a single remote Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 08/11] gitweb: refactor repository URL printing Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 09/11] gitweb: provide a routine to display (sub)sections Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 10/11] gitweb: group remote heads by remote Giuseppe Bilotta
2010-11-11 19:25   ` Jakub Narebski
2010-11-12  8:13     ` [PATCHv7bis " Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 11/11] git instaweb: enable remote_heads Giuseppe Bilotta
2010-11-11 19:29 ` [PATCHv7 00/11] gitweb: remote_heads feature Jakub Narebski
2010-11-12  8:05   ` Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289478378-15604-6-git-send-email-giuseppe.bilotta@gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).