From: Vitor Antunes <vitor.hda@gmail.com>
To: git@vger.kernel.org
Cc: Vitor Antunes <vitor.hda@gmail.com>
Subject: [PATCH 1/2] git-p4: Don't edit renamed files if not necessary.
Date: Fri, 19 Nov 2010 01:38:12 +0000 [thread overview]
Message-ID: <1290130693-30855-2-git-send-email-vitor.hda@gmail.com> (raw)
In-Reply-To: <1290130693-30855-1-git-send-email-vitor.hda@gmail.com>
Only open files for edit after integrating if the SHA1 of source and
destination differ from each other.
Also added git config option to allow permanent rename detection.
The detectRenames option should be set to the desired threshold value.
Rename detection can still be enabled through -M option.
---
contrib/fast-import/git-p4 | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 04ce7e3..ba18512 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -613,7 +613,13 @@ class P4Submit(Command):
def applyCommit(self, id):
print "Applying %s" % (read_pipe("git log --max-count=1 --pretty=oneline %s" % id))
- diffOpts = ("", "-M")[self.detectRename]
+
+ detectRenames = gitConfig("git-p4.detectRenames")
+ if len(detectRenames) > 0:
+ diffOpts = "-M%s" % detectRenames
+ else:
+ diffOpts = ("", "-M")[self.detectRenames]
+
diff = read_pipe_lines("git diff-tree -r %s \"%s^\" \"%s\"" % (diffOpts, id, id))
filesToAdd = set()
filesToDelete = set()
@@ -640,7 +646,8 @@ class P4Submit(Command):
elif modifier == "R":
src, dest = diff['src'], diff['dst']
p4_system("integrate -Dt \"%s\" \"%s\"" % (src, dest))
- p4_system("edit \"%s\"" % (dest))
+ if diff['src_sha1'] != diff['dst_sha1']:
+ p4_system("edit \"%s\"" % (dest))
if isModeExecChanged(diff['src_mode'], diff['dst_mode']):
filesToChangeExecBit[dest] = diff['dst_mode']
os.unlink(dest)
--
1.7.2.3
next prev parent reply other threads:[~2010-11-19 1:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 1:38 [PATCH 0/2] git-p4: Rename and copy detection improvements Vitor Antunes
2010-11-19 1:38 ` Vitor Antunes [this message]
2010-11-19 12:14 ` [PATCH 1/2] git-p4: Don't edit renamed files if not necessary Vitor Antunes
2010-11-25 1:26 ` [PATCH] git-p4: Corrected typo Vitor Antunes
2011-01-27 23:35 ` Vitor Antunes
2011-01-28 15:19 ` Thomas Berg
2011-01-29 2:41 ` Vitor Antunes
2011-01-30 23:21 ` Vitor Antunes
2011-01-30 23:34 ` Thomas Berg
2011-01-31 11:25 ` Vitor Antunes
2011-01-31 12:51 ` Thomas Berg
2011-01-31 13:39 ` Vitor Antunes
2011-01-31 15:54 ` Vitor Antunes
2011-02-04 8:59 ` Thomas Berg
2010-11-19 1:38 ` [PATCH 2/2] git-p4: Added copy detection support Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290130693-30855-2-git-send-email-vitor.hda@gmail.com \
--to=vitor.hda@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).