* [PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories.
@ 2010-11-19 20:43 Bert Wesarg
2010-11-22 21:58 ` Pat Thoyts
0 siblings, 1 reply; 2+ messages in thread
From: Bert Wesarg @ 2010-11-19 20:43 UTC (permalink / raw)
To: Pat Thoyts; +Cc: Bert Wesarg, Shawn O. Pearce, git
browser_path used to end with a slash, so the regexp matches the empty string
and therefore removes nothing.
Fix this.
Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
git-gui/lib/browser.tcl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl
index c241572..a8c6223 100644
--- a/git-gui/lib/browser.tcl
+++ b/git-gui/lib/browser.tcl
@@ -121,7 +121,7 @@ method _parent {} {
if {$browser_stack eq {}} {
regsub {:.*$} $browser_path {:} browser_path
} else {
- regsub {/[^/]+$} $browser_path {} browser_path
+ regsub {/[^/]+/$} $browser_path {/} browser_path
}
set browser_status [mc "Loading %s..." $browser_path]
_ls $this [lindex $parent 0] [lindex $parent 1]
--
tg: (6f10c41..) bw/git-gui/fix-browser-up (depends on: master)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories.
2010-11-19 20:43 [PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories Bert Wesarg
@ 2010-11-22 21:58 ` Pat Thoyts
0 siblings, 0 replies; 2+ messages in thread
From: Pat Thoyts @ 2010-11-22 21:58 UTC (permalink / raw)
To: Bert Wesarg; +Cc: Shawn O. Pearce, git
Bert Wesarg <bert.wesarg@googlemail.com> writes:
>browser_path used to end with a slash, so the regexp matches the empty string
>and therefore removes nothing.
>
>Fix this.
>
>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>
>---
> git-gui/lib/browser.tcl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl
>index c241572..a8c6223 100644
>--- a/git-gui/lib/browser.tcl
>+++ b/git-gui/lib/browser.tcl
>@@ -121,7 +121,7 @@ method _parent {} {
> if {$browser_stack eq {}} {
> regsub {:.*$} $browser_path {:} browser_path
> } else {
>- regsub {/[^/]+$} $browser_path {} browser_path
>+ regsub {/[^/]+/$} $browser_path {/} browser_path
> }
> set browser_status [mc "Loading %s..." $browser_path]
> _ls $this [lindex $parent 0] [lindex $parent 1]
Thanks - applied to git-gui master.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-23 2:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-19 20:43 [PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories Bert Wesarg
2010-11-22 21:58 ` Pat Thoyts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).