From: "Diego Elio Pettenò" <flameeyes@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] imap-send: link against libcrypto for HMAC and others
Date: Wed, 24 Nov 2010 14:55:16 +0100 [thread overview]
Message-ID: <1290606916-14550-1-git-send-email-flameeyes@gmail.com> (raw)
When using stricter linkers, such as GNU gold or Darwin ld, transitive
dependencies are not counted towards symbol resolution. If we don't link
imap-send to libcrypto, we'll have undefined references to the HMAC_*,
EVP_* and ERR_* functions families.
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 1f1ce04..c8377d4 100644
--- a/Makefile
+++ b/Makefile
@@ -1927,7 +1927,7 @@ git-%$X: %.o $(GITLIBS)
git-imap-send$X: imap-send.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
- $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
+ $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
--
1.7.3.2
next reply other threads:[~2010-11-24 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:55 Diego Elio Pettenò [this message]
2010-11-24 20:01 ` [PATCH] imap-send: link against libcrypto for HMAC and others Junio C Hamano
2010-11-24 20:03 ` Diego Elio Pettenò
2010-12-06 5:28 ` Anders Kaseorg
2010-12-06 5:39 ` Diego Elio Pettenò
2010-12-06 6:06 ` Jonathan Nieder
2010-12-06 6:11 ` Junio C Hamano
2010-12-08 1:51 ` Jared Hance
2010-12-08 2:12 ` Junio C Hamano
2010-12-08 4:53 ` Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290606916-14550-1-git-send-email-flameeyes@gmail.com \
--to=flameeyes@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).