git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	rctay@nus.edu.sg
Subject: [PATCH v3 4/9] url: add str wrapper for end_url_with_slash()
Date: Thu, 25 Nov 2010 16:21:05 +0800	[thread overview]
Message-ID: <1290673270-4284-5-git-send-email-rctay89@gmail.com> (raw)
In-Reply-To: <1290673270-4284-4-git-send-email-rctay89@gmail.com>

Helped-by: Johnathan Nieder <jrnieder@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---

Changed from v2: removed pointer check before free(), as suggested by Johnathan.

 url.c |    7 +++++++
 url.h |    1 +
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/url.c b/url.c
index 7cebc64..6a54959 100644
--- a/url.c
+++ b/url.c
@@ -132,3 +132,10 @@ void end_url_with_slash(struct strbuf *buf, const char *url)
 	if (buf->len && buf->buf[buf->len - 1] != '/')
 		strbuf_addstr(buf, "/");
 }
+
+void str_end_url_with_slash(const char *url, char **dest) {
+	struct strbuf buf = STRBUF_INIT;
+	end_url_with_slash(&buf, url);
+	free(*dest);
+	*dest = strbuf_detach(&buf, NULL);
+}
diff --git a/url.h b/url.h
index 8cb74d4..7100e32 100644
--- a/url.h
+++ b/url.h
@@ -8,5 +8,6 @@ extern char *url_decode_parameter_name(const char **query);
 extern char *url_decode_parameter_value(const char **query);
 
 extern void end_url_with_slash(struct strbuf *buf, const char *url);
+extern void str_end_url_with_slash(const char *url, char **dest);
 
 #endif /* URL_H */
-- 
1.7.3.2.495.gc7b3f

  reply	other threads:[~2010-11-25  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1290433298-6000-1-git-send-email-rctay89@gmail.com>
     [not found] ` <1290433657-4444-1-git-send-email-rctay89@gmail.com>
     [not found]   ` <1290433657-4444-2-git-send-email-rctay89@gmail.com>
     [not found]     ` <1290433657-4444-3-git-send-email-rctay89@gmail.com>
     [not found]       ` <1290433657-4444-4-git-send-email-rctay89@gmail.com>
2010-11-22 17:14         ` [PATCH v2 3/7] url: add str wrapper for end_url_with_slash() Jonathan Nieder
2010-11-22 17:19           ` Tay Ray Chuan
2010-11-25  8:21 ` [PATCH v3 0/9] http: end urls with slash Tay Ray Chuan
2010-11-25  8:21   ` [PATCH v3 1/9] t5550-http-fetch: add missing '&&' Tay Ray Chuan
2010-11-25  8:21     ` [PATCH v3 2/9] t5550-http-fetch: add test for http-fetch Tay Ray Chuan
2010-11-25  8:21       ` [PATCH v3 3/9] shift end_url_with_slash() from http.[ch] to url.[ch] Tay Ray Chuan
2010-11-25  8:21         ` Tay Ray Chuan [this message]
2010-11-25  8:21           ` [PATCH v3 5/9] http-backend: use end_url_with_slash() Tay Ray Chuan
2010-11-25  8:21             ` [PATCH v3 6/9] http-push: Normalise directory names when pushing to some WebDAV servers Tay Ray Chuan
2010-11-25  8:21               ` [PATCH v3 7/9] http-push: check path length before using it Tay Ray Chuan
2010-11-25  8:21                 ` [PATCH v3 8/9] http-push: add trailing slash at arg-parse time, instead of later on Tay Ray Chuan
2010-11-25  8:21                   ` [PATCH v3 9/9] http-fetch: rework url handling Tay Ray Chuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290673270-4284-5-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=rctay@nus.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).