git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>
Subject: [PATCH v3 5/9] http-backend: use end_url_with_slash()
Date: Thu, 25 Nov 2010 16:21:06 +0800	[thread overview]
Message-ID: <1290673270-4284-6-git-send-email-rctay89@gmail.com> (raw)
In-Reply-To: <1290673270-4284-5-git-send-email-rctay89@gmail.com>

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 http-backend.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/http-backend.c b/http-backend.c
index 14c90c2..8501504 100644
--- a/http-backend.c
+++ b/http-backend.c
@@ -510,9 +510,7 @@ static char* getdir(void)
 			die("GIT_PROJECT_ROOT is set but PATH_INFO is not");
 		if (daemon_avoid_alias(pathinfo))
 			die("'%s': aliased", pathinfo);
-		strbuf_addstr(&buf, root);
-		if (buf.buf[buf.len - 1] != '/')
-			strbuf_addch(&buf, '/');
+		end_url_with_slash(&buf, root);
 		if (pathinfo[0] == '/')
 			pathinfo++;
 		strbuf_addstr(&buf, pathinfo);
-- 
1.7.3.2.495.gc7b3f

  reply	other threads:[~2010-11-25  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1290433298-6000-1-git-send-email-rctay89@gmail.com>
     [not found] ` <1290433657-4444-1-git-send-email-rctay89@gmail.com>
     [not found]   ` <1290433657-4444-2-git-send-email-rctay89@gmail.com>
     [not found]     ` <1290433657-4444-3-git-send-email-rctay89@gmail.com>
     [not found]       ` <1290433657-4444-4-git-send-email-rctay89@gmail.com>
2010-11-22 17:14         ` [PATCH v2 3/7] url: add str wrapper for end_url_with_slash() Jonathan Nieder
2010-11-22 17:19           ` Tay Ray Chuan
2010-11-25  8:21 ` [PATCH v3 0/9] http: end urls with slash Tay Ray Chuan
2010-11-25  8:21   ` [PATCH v3 1/9] t5550-http-fetch: add missing '&&' Tay Ray Chuan
2010-11-25  8:21     ` [PATCH v3 2/9] t5550-http-fetch: add test for http-fetch Tay Ray Chuan
2010-11-25  8:21       ` [PATCH v3 3/9] shift end_url_with_slash() from http.[ch] to url.[ch] Tay Ray Chuan
2010-11-25  8:21         ` [PATCH v3 4/9] url: add str wrapper for end_url_with_slash() Tay Ray Chuan
2010-11-25  8:21           ` Tay Ray Chuan [this message]
2010-11-25  8:21             ` [PATCH v3 6/9] http-push: Normalise directory names when pushing to some WebDAV servers Tay Ray Chuan
2010-11-25  8:21               ` [PATCH v3 7/9] http-push: check path length before using it Tay Ray Chuan
2010-11-25  8:21                 ` [PATCH v3 8/9] http-push: add trailing slash at arg-parse time, instead of later on Tay Ray Chuan
2010-11-25  8:21                   ` [PATCH v3 9/9] http-fetch: rework url handling Tay Ray Chuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290673270-4284-6-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).