git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Christian Couder <christian.couder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCHv2 0/7] web--browse cleanup and extensions
Date: Fri,  3 Dec 2010 17:47:34 +0100	[thread overview]
Message-ID: <1291394861-11989-1-git-send-email-giuseppe.bilotta@gmail.com> (raw)

This second issue of the web--browse cleanup and extension patchset
has seen some stylistic changes in the first patches as discussed on the
ML, and a new patch to add support for the BROWSER env var. Support for
xdg-open is still missing, due to the lack of an obvious way to suggest
opening pages in new tabs (same reason why we don't directly support
Debian's sensible-browser).

I'm quite convinced that the first 4 patches (up to the "support opera,
seamonkey and elinks" patch, inclusive) are ready for merging.

The fifth patch is slightly more extensive than in the previous
iteration, including chromium-browser as a supported option, but still
looking for chromium-browser first even when browser=chromium.

The last two patches are more RFCish. I tried to include the changes
suggested by Christian, unless of course I forgot something. Suggestions
on possible ways to improve the proposed approach are welcome.

Giuseppe Bilotta (7):
  CodingGuidelines: mention whitespace preferences for shell scripts
  web--browse: coding style
  web--browse: split valid_tool list
  web--browse: support opera, seamonkey and elinks
  web--browse: better support for chromium
  web--browse: use (x-)www-browser if available
  web--browse: look at the BROWSER env var

 Documentation/CodingGuidelines    |    4 +
 Documentation/git-web--browse.txt |   10 ++
 git-web--browse.sh                |  276 +++++++++++++++++++++++++------------
 3 files changed, 203 insertions(+), 87 deletions(-)

-- 
1.7.3.2.664.g294b8.dirty

             reply	other threads:[~2010-12-03 16:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 16:47 Giuseppe Bilotta [this message]
2010-12-03 16:47 ` [PATCHv2 1/7] CodingGuidelines: mention whitespace preferences for shell scripts Giuseppe Bilotta
2010-12-03 21:43   ` Junio C Hamano
2010-12-03 22:02     ` Giuseppe Bilotta
2010-12-03 22:28       ` Junio C Hamano
2010-12-03 22:46         ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 2/7] web--browse: coding style Giuseppe Bilotta
2010-12-07 23:38   ` Junio C Hamano
2010-12-03 16:47 ` [PATCHv2 3/7] web--browse: split valid_tool list Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 4/7] web--browse: support opera, seamonkey and elinks Giuseppe Bilotta
2010-12-03 22:01   ` Junio C Hamano
2010-12-03 22:22     ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 5/7] web--browse: better support for chromium Giuseppe Bilotta
2010-12-03 21:57   ` Junio C Hamano
2010-12-03 22:25     ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 6/7] web--browse: use (x-)www-browser if available Giuseppe Bilotta
2010-12-03 17:40   ` Christian Couder
2010-12-03 17:57     ` Giuseppe Bilotta
2010-12-03 22:15   ` Junio C Hamano
2010-12-03 22:45     ` Giuseppe Bilotta
2010-12-04  0:42       ` Jonathan Nieder
2010-12-04  7:49         ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 7/7] web--browse: look at the BROWSER env var Giuseppe Bilotta
2010-12-03 17:08   ` Jonathan Nieder
2010-12-03 17:16     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291394861-11989-1-git-send-email-giuseppe.bilotta@gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).