From: "Diego Elio Pettenò" <flameeyes@gmail.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] imap-send: link against libcrypto for HMAC and others
Date: Mon, 06 Dec 2010 06:39:38 +0100 [thread overview]
Message-ID: <1291613978.4756.157.camel@yamato.local> (raw)
In-Reply-To: <1291613304.3339.12.camel@fixed-disk>
Il giorno lun, 06/12/2010 alle 00.28 -0500, Anders Kaseorg ha scritto:
> This broke the build with NO_OPENSSL=1, so Debian will need to revert
> it:
I'll try a NO_OPENSSL build later on today and see to get it fixed.
> Also, the Makefile already has a NEEDS_CRYPTO_WITH_SSL flag that’s
> automatically set on Darwin, Windows, and MinGW. We shouldn’t have two
> mechanisms for addressing the same problem; maybe we just need to enable
> the existing flag on more (or all) platforms?
No, these should be different issues; you may have a libssl (which uses
libcrypto) requiring libcrypto to be linked in, even if you only use
interfaces from libssl (and that's what NEEDS_CRYPTO_WITH_SSL seem to be
designed to deal with), but in this case what you have is rather
imap-send using the libcrypto interfaces _as well as_ the libssl
interfaces.
I have blogged a detailed analysis of the problem, if you wish to see
the details:
http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing
--
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/
If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/
next prev parent reply other threads:[~2010-12-06 5:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:55 [PATCH] imap-send: link against libcrypto for HMAC and others Diego Elio Pettenò
2010-11-24 20:01 ` Junio C Hamano
2010-11-24 20:03 ` Diego Elio Pettenò
2010-12-06 5:28 ` Anders Kaseorg
2010-12-06 5:39 ` Diego Elio Pettenò [this message]
2010-12-06 6:06 ` Jonathan Nieder
2010-12-06 6:11 ` Junio C Hamano
2010-12-08 1:51 ` Jared Hance
2010-12-08 2:12 ` Junio C Hamano
2010-12-08 4:53 ` Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291613978.4756.157.camel@yamato.local \
--to=flameeyes@gmail.com \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).